Opened 4 months ago

Closed 3 months ago

Last modified 38 hours ago

#31457 closed defect (fixed)

disable per-installation profiles

Reported by: mcs Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909R, BugSmashFund
Cc: Actual Points: 0.25
Parent ID: Points: 0.25
Reviewer: Sponsor:

Description

Firefox ESR68 includes installation-specific profiles. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1474285

With our current nightly builds, this causes an extra profile directory to be created and used (and probably our bundled browser profile is not be used on Linux and Windows).

We should figure out how to disable this feature or modify it to be compatible with the way we crate and use browser profiles).

Child Tickets

Change History (17)

comment:1 Changed 4 months ago by mcs

Here is a sample profiles.ini file from macOS (notice the .default-default profile):

[Profile1]
Name=default
IsRelative=1
Path=h4qs0l4w.default
Default=1

[Profile0]
Name=default-default
IsRelative=1
Path=xkngrdjb.default-default

[General]
StartWithLastProfile=1
Version=2

[Install5A04EA4A1373107B]
Default=xkngrdjb.default-default
Locked=1

comment:2 Changed 4 months ago by cypherpunks

Looks like part of the official (but weird) downgrade support:
"Always creates an old-style default profile if one does not exist to allow
previous versions of the application to use a different profile."

comment:3 Changed 4 months ago by boklm

It seems the MOZ_LEGACY_PROFILES environment variable can be set to disable this feature. On Linux we could set it in the start script, however I'm not sure we can easily set environment variables on Windows and macOS, so maybe patching to disable it will be needed.

comment:4 Changed 4 months ago by pili

Sponsor: Sponsor44-can

Tagging with Sponsor 44

comment:5 in reply to:  3 ; Changed 3 months ago by mcs

Replying to boklm:

It seems the MOZ_LEGACY_PROFILES environment variable can be set to disable this feature. On Linux we could set it in the start script, however I'm not sure we can easily set environment variables on Windows and macOS, so maybe patching to disable it will be needed.

Thanks. We may also be able to disable this by adding the following to our .mozconfig files (but I have not tried yet):

ac_add_options "MOZ_DEDICATED_PROFILES="

comment:6 Changed 3 months ago by gk

Keywords: tbb-9.0-must-alpha added; tbb-9.0-must-nightly removed

Move must-nightly items to must-alpha ones.

comment:7 Changed 3 months ago by gk

Keywords: TorBrowserTeam201909 added

Moving must-alpha tickets to September.

comment:8 Changed 3 months ago by pili

Points: 0.25

comment:9 in reply to:  5 Changed 3 months ago by mcs

Keywords: TorBrowserTeam201909R added; TorBrowserTeam201909 removed
Status: newneeds_review

Replying to mcs:

We may also be able to disable this by adding the following to our .mozconfig files (but I have not tried yet):

ac_add_options "MOZ_DEDICATED_PROFILES="

The above does not work. It seems that options that are defined using project_flag cannot be overridden easily... or at least Kathy and I could not figure out how to do so via .mozconfig. Here is a patch that changes the default value:

https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug31457-01&id=646a7e897d3b313fadc37b52b147cc85dbd53fad

comment:10 Changed 3 months ago by cypherpunks

+export MOZ_DEDICATED_PROFILES=0?

comment:11 in reply to:  10 Changed 3 months ago by mcs

Replying to cypherpunks:

+export MOZ_DEDICATED_PROFILES=0?

Thanks, but we tried various things like that. The error is:

 0:01.89 mozbuild.configure.options.InvalidOptionError: MOZ_DEDICATED_PROFILES=0 can not be set by mozconfig. Values are accepted from: implied

comment:12 Changed 3 months ago by cypherpunks

comment:13 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

It's a pity Mozilla does not provide an easier, cross-platform way of disabling this feature. But here we are. The change looks good to me and got cherry-picked onto tor-browser-68.1.0esr-9.0-2 (commit 31d00e2f9c23184c2378d125c11a4e1219a8b59e).

comment:14 Changed 3 months ago by pili

Hi,

Can we update the Actual points so that we can start seeing how well we are estimating?

Thanks!

comment:15 Changed 3 months ago by mcs

Actual Points: 0.25

comment:16 Changed 38 hours ago by pili

Keywords: BugSmashFund added

BugSmashFund can be used for the ESR work done so far

comment:17 Changed 38 hours ago by pili

Sponsor: Sponsor44-can

Sponsor 44 only covered PM and Team Lead work

Note: See TracTickets for help on using tickets.