Opened 2 months ago

Closed 8 weeks ago

#31458 closed defect (fixed)

Facilitate getting the widl fixes from wine into mingw and update the mingw-w64 project in tor-browser-build once they are in

Reported by: pospeselr Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201908R, tbb-9.0-must-alpha
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by pospeselr)

The patchset should be landing in wine by the end of August 2019. We will need to bug the mingw folks to pull in the latest wine version (or just the widl) and then update mingw-w64's projects file in tor-browser-build. I will also need to verify the final built IA2 bits match between our current build and this future build.

Child Tickets

Change History (8)

comment:1 Changed 2 months ago by pospeselr

Description: modified (diff)

comment:2 Changed 2 months ago by pospeselr

Jacekc fast-tracked the widl changes to mingw-w64 ( commit 60d5a66ae51da0e01f3b47de366ae639b01ee189 ) so we can test our ESR68 builds.

Verified 64-bit windows build on Windows 10 64 bit: NVDA works as expected (reads page content, keyboard navigation works) and a brute force IA2 tree traversal ( via this tool: https://github.com/pospeselr/ia2_test ) also succeeds without crashing on various pages.

Our 32-bit build isn't quite ready yet, but once it is I'll do the same test on both 32-bit windows and on 64-bit WoW before resolving this.

comment:3 Changed 2 months ago by gk

Keywords: TorBrowserTeam201908 tbb-9.0-must-alpha added

How about:

https://people.torproject.org/~gk/testbuilds/torbrowser-install-tbb-nightly_28238_2_en-US.exe
https://people.torproject.org/~gk/testbuilds/torbrowser-install-tbb-nightly_28238_2_en-US.exe.asc

I guess we could use this bug to actually remove the mingw-w64 related patches in tor-browser-build and bump the mingw-w64 version for non-browser projects to the one used in building the browser to have them in sync.

comment:4 Changed 2 months ago by pospeselr

Verified the above build working correctly on 32-bit Windows 7, now setting up 64-bit Windows 7 WoW.

comment:5 Changed 2 months ago by pospeselr

And verified 32-bit Tor Browser is working with NVDA on 64-bit Windows 7.

comment:6 Changed 2 months ago by pospeselr

Commit to remove the mingw-w64 widl pre-build patch:

tor-browser-build: https://gitweb.torproject.org/user/richard/tor-browser-build.git/commit/?h=bug_31458

comment:7 Changed 2 months ago by pospeselr

Keywords: TorBrowserTeam201908R added; TorBrowserTeam201908 removed
Status: assignedneeds_review

comment:8 Changed 8 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good, thanks! I cherry-picked your patch to master (commit 89e6eed8ce459dfeae17ce886f35df209760965c) and adapted the commit message a bit.

Note: See TracTickets for help on using tickets.