Facilitate getting the widl fixes from wine into mingw and update the mingw-w64 project in tor-browser-build once they are in

The patchset should be landing in wine by the end of August 2019. We will need to bug the mingw folks to pull in the latest wine version (or just the widl) and then update mingw-w64's projects file in tor-browser-build. I will also need to verify the final built IA2 bits match between our current build and this future build.

added TorBrowserTeam201908R component::applications/tor browser owner::pospeselr priority::medium resolution::fixed severity::normal status::closed tbb-9.0-must-alpha type::defect labels

Trac:
Description: The patchset should be landing in wine by the end of August 2019. We will need to bug the mingw folks to pull in the latest wine version (or just the widl) and then update mingw-w64's projects file in tor-browser-build

to

The patchset should be landing in wine by the end of August 2019. We will need to bug the mingw folks to pull in the latest wine version (or just the widl) and then update mingw-w64's projects file in tor-browser-build. I will also need to verify the final built IA2 bits match between our current build and this future build.

Jacekc fast-tracked the widl changes to mingw-w64 ( commit 60d5a66ae51da0e01f3b47de366ae639b01ee189 ) so we can test our ESR68 builds.

Verified 64-bit windows build on Windows 10 64 bit: NVDA works as expected (reads page content, keyboard navigation works) and a brute force IA2 tree traversal ( via this tool: https://github.com/pospeselr/ia2_test ) also succeeds without crashing on various pages.

Our 32-bit build isn't quite ready yet, but once it is I'll do the same test on both 32-bit windows and on 64-bit WoW before resolving this.

How about:

https://people.torproject.org/~gk/testbuilds/torbrowser-install-tbb-nightly_28238_2_en-US.exe https://people.torproject.org/~gk/testbuilds/torbrowser-install-tbb-nightly_28238_2_en-US.exe.asc

I guess we could use this bug to actually remove the mingw-w64 related patches in tor-browser-build and bump the mingw-w64 version for non-browser projects to the one used in building the browser to have them in sync.

Trac:
Keywords: N/A deleted, tbb-9.0-must-alpha, TorBrowserTeam201908 added

Verified the above build working correctly on 32-bit Windows 7, now setting up 64-bit Windows 7 WoW.

And verified 32-bit Tor Browser is working with NVDA on 64-bit Windows 7.

Commit to remove the mingw-w64 widl pre-build patch:

tor-browser-build: https://gitweb.torproject.org/user/richard/tor-browser-build.git/commit/?h=bug_31458

Trac:
Status: assigned to needs_review
Keywords: TorBrowserTeam201908 deleted, TorBrowserTeam201908R added

Looks good, thanks! I cherry-picked your patch to master (commit 89e6eed8ce459dfeae17ce886f35df209760965c) and adapted the commit message a bit.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-browser#31458 (closed)