Opened 2 months ago

Closed 7 weeks ago

Last modified 7 weeks ago

#31463 closed defect (fixed)

Redundant build exclusion not working corrently on travis

Reported by: Sebastian Owned by:
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version: Tor: 0.3.5.4-alpha
Severity: Normal Keywords: asn-merge-backport, nickm-merge-backport, consider-backport-immediately, tor-ci-speed, 035-backport, 040-backport, 041-backport
Cc: asn, nickm Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: teor Sponsor:

Description

Since the hardening options are used again we're using one more builder than intended

Child Tickets

Change History (9)

comment:1 Changed 2 months ago by teor

Keywords: tor-ci 035-backport-maybe 040-backport-maybe 041-backport-maybe added; CI removed
Milestone: Tor: unspecifiedTor: 0.4.2.x-final
Reviewer: nickmteor

I'll work out how far we need to backport this when I do the review.

comment:3 Changed 2 months ago by Sebastian

Status: newneeds_review

comment:4 Changed 8 weeks ago by teor

Actual Points: 0.1
Keywords: consider-backport-immediately tor-ci-speed 035-backport 040-backport 041-backport added; tor-ci 035-backport-maybe 040-backport-maybe 041-backport-maybe removed
Points: 0.1
Status: needs_reviewmerge_ready
Version: Tor: unspecifiedTor: 0.3.5.4-alpha

This bug was introduced in the fixes for #27272, #27273, and #27274 in 0.3.5.4-alpha. So we should backport it to 0.3.5 and later.

Since it's a CI fix, we can backport as soon as the master merge CI finishes successfully.

Here are the backport branches:

Clean merges, but testing CI jobs (there should be 12):

comment:5 Changed 8 weeks ago by teor

All PR builds have 12 jobs.

comment:6 Changed 8 weeks ago by nickm

Milestone: Tor: 0.4.2.x-finalTor: 0.4.0.x-final

Merged to 0.4.1 and forward; marking for backport.

comment:7 Changed 7 weeks ago by teor

Cc: asn nickm added
Keywords: asn-merge-backport nickm-merge-backport added

Hi asn, nickm, can you please test the new push-all.sh script in #29879 by merging this backport to 0.3.5 and pushing using:

TOR_PUSH_DELAY=5 git-push-all.sh

This CI change is safe to backport immediately.

comment:8 Changed 7 weeks ago by asn

Resolution: fixed
Status: merge_readyclosed

I merged it teor and the delay functionality worked for me. Please reopen if something was not done right.

comment:9 Changed 7 weeks ago by teor

Looks good to me.

Note: See TracTickets for help on using tickets.