Opened 4 weeks ago

Closed 11 days ago

#31476 closed task (fixed)

Practracker: document new features

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: practracker, tech-debt, refactoring, easy, 041-deferred-20190530, network-team-roadmap-july, dgoulet-merge
Cc: nickm, teor, asn Actual Points: .1
Parent ID: #29746 Points: .2
Reviewer: catalyst Sponsor: Sponsor31-must

Description

On 31176, asn notes:

We should update the file-level comment of practracker.py to mention that we are now checking for include dependecies too. Same goes for the header of exceptions.txt .

And maybe it's time to make a small README file to specify all the metrics that practracker is currently looking for, before they become too many?

This is a good idea

Child Tickets

Change History (9)

comment:1 Changed 4 weeks ago by nickm

Sponsor: Sponsor31-must

comment:2 Changed 4 weeks ago by nickm

Actual Points: .1
Status: assignedneeds_review

comment:3 Changed 3 weeks ago by asn

Status: needs_reviewneeds_revision

(I took a quick look: I see that the README finishes incomplete.)

comment:4 Changed 3 weeks ago by nickm

Status: needs_revisionneeds_review

Whoops; I had a fix for that but apparently I had forgotten to force-push it to github.

comment:5 Changed 3 weeks ago by dgoulet

Reviewer: catalyst

comment:6 in reply to:  2 Changed 3 weeks ago by catalyst

Status: needs_reviewneeds_revision

Replying to nickm:

See branch #31476 with PR at https://github.com/torproject/tor/pull/1246

Thanks! Mostly looks good. I would like to use something other than "H file" to refer to header files, though, because it can be a little confusing. As far as I know, we don't write anything in a programming language called "H". Maybe ".c files" and ".h file"? or "C files" and "header files"?

comment:7 Changed 2 weeks ago by nickm

Status: needs_revisionneeds_review

Thanks for the review! I've pushed a commit to fix this.

(I went with ".c files and .h files", and not with "C files and header files" since technically, C header files are also C.)

comment:8 in reply to:  7 Changed 12 days ago by catalyst

Status: needs_reviewmerge_ready

Replying to nickm:

Thanks for the review! I've pushed a commit to fix this.

(I went with ".c files and .h files", and not with "C files and header files" since technically, C header files are also C.)

Thanks! Looks good now.

comment:9 Changed 11 days ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.