Practracker: document new features

On 31176, asn notes:

We should update the file-level comment of practracker.py to mention that we are now checking for include dependecies too. Same goes for the header of exceptions.txt .

And maybe it's time to make a small README file to specify all the metrics that practracker is currently looking for, before they become too many?

This is a good idea

changed milestone to %Tor: 0.4.2.x-final

added 041-deferred-20190530 actualpoints::.1 component::core tor/tor dgoulet-merge easy milestone::Tor: 0.4.2.x-final network-team-roadmap-july owner::nickm points::.2 practracker priority::medium refactoring resolution::fixed reviewer::catalyst severity::normal sponsor::31-must status::closed tech-debt type::task labels

Trac:
Sponsor: N/A to Sponsor31-must

See branch #31476 (moved) with PR at https://github.com/torproject/tor/pull/1246

Trac:
Status: assigned to needs_review
Actualpoints: N/A to .1

(I took a quick look: I see that the README finishes incomplete.)

Trac:
Status: needs_review to needs_revision

Whoops; I had a fix for that but apparently I had forgotten to force-push it to github.

Trac:
Status: needs_revision to needs_review

Trac:
Reviewer: N/A to catalyst

Replying to nickm:

See branch #31476 (moved) with PR at https://github.com/torproject/tor/pull/1246 Thanks! Mostly looks good. I would like to use something other than "H file" to refer to header files, though, because it can be a little confusing. As far as I know, we don't write anything in a programming language called "H". Maybe ".c files" and ".h file"? or "C files" and "header files"?

Trac:
Status: needs_review to needs_revision

Thanks for the review! I've pushed a commit to fix this.

(I went with ".c files and .h files", and not with "C files and header files" since technically, C header files are also C.)

Trac:
Status: needs_revision to needs_review

Replying to nickm:

Thanks for the review! I've pushed a commit to fix this.

(I went with ".c files and .h files", and not with "C files and header files" since technically, C header files are also C.) Thanks! Looks good now.

Trac:
Status: needs_review to merge_ready

Merged!

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

ticket31476 was accidentally pushed to git.tpo/tor.git, see #31479 (moved) for the cleanup.

Trac:
Parent: #29746 (moved) to N/A

closed

changed time estimate to 1h 36m

added 48m of time spent

moved to tpo/core/tor#31476 (closed)