Opened 8 weeks ago

Closed 7 weeks ago

#31490 closed defect (fixed)

hs-v3: Turns out the hs_ident circuit_type is not used

Reported by: dgoulet Owned by: neel
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs asn-merge nickm-merge
Cc: asn, neel Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor: Sponsor27-can

Description

I stumble upon this while investigating #30200. My HS debugging showed up with circuit type set to INTRO for a rendezvous circuit.

In, one of the most insane function we have, circuit_get_open_circ_or_launch(), towards the end, we set the HS identifier of the open circuit:

          circ->hs_ident =
            hs_ident_circuit_new(&edge_conn->hs_ident->identity_pk,
                                 HS_IDENT_CIRCUIT_INTRO);

... notice, we only use INTRO type, never the RENDEZVOUS one.

Further looking at it, it appears that the hs_ident->circuit_type field is just pointless. Client will only set the INTRO (see code above) and the service will properly set both. But then after that, it is just never used.

I propose we either remove it or fix the client side because if we ever rely on that field, it is of today really wrong client side.

Child Tickets

Change History (5)

comment:1 Changed 8 weeks ago by neel

Cc: neel added
Owner: set to neel
Status: newassigned

comment:2 Changed 8 weeks ago by neel

Status: assignedneeds_review

comment:3 Changed 7 weeks ago by dgoulet

Reviewer: dgoulet

comment:4 Changed 7 weeks ago by dgoulet

Keywords: asn-merge nickm-merge added
Status: needs_reviewmerge_ready

ack.

comment:5 Changed 7 weeks ago by asn

Resolution: fixed
Status: merge_readyclosed

merged!

Note: See TracTickets for help on using tickets.