Opened 8 weeks ago

Closed 3 weeks ago

Last modified 13 days ago

#31491 closed defect (fixed)

clean up the old meek http helper browser profiles

Reported by: mcs Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Launcher Version:
Severity: Normal Keywords: meek, utls, ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909R
Cc: tbb-team, dcf Actual Points: 1
Parent ID: #29430 Points: 4
Reviewer: Sponsor:

Description

Now that we are using obfs4proxy's meek_lite in Tor Browser, we should add code that removes the old meek http helper browser profiles.

This is probably most easily done by Tor Launcher during startup since it already knows the file system path for each profile.

Child Tickets

Change History (7)

comment:1 Changed 7 weeks ago by gk

Keywords: tbb-9.0-must-alpha added

comment:2 Changed 7 weeks ago by brade

Cc: dcf added

Since it will not be harmful to leave the unused meek helper profiles on disk for a little while, Mark and I do not plan to work on this before the first ESR68-based alpha. We believe this task can wait until the next alpha release (assuming we make additional alpha releases before our first stable release).

cc: dcf to make them aware that Tor Browser will (soon) automatically remove the old meek helper profiles (which might be surprising if they are using them for testing).

comment:3 Changed 6 weeks ago by gk

Moving must-alpha tickets to September.

comment:4 Changed 6 weeks ago by pili

Points: 4

comment:5 Changed 4 weeks ago by mcs

Keywords: TorBrowserTeam201909R added; TorBrowserTeam201909 removed
Status: assignedneeds_review

We ended up handling this in two different ways. For Linux and Windows we can have the updater take care of removal:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug31491-01&id=7154ffb92a16d7bf630cbeec0e01dfce0930a7dc

On macOS the updater is already removing the profile template from the .app bundle, but we need to have Tor Launcher clean up any profiles that were created under TorBrowser-Data:
https://gitweb.torproject.org/user/brade/tor-launcher.git/commit/?h=bug31491-01&id=d78a233bc597c8df63e794f880a1a7f54fb9cebd

Please review.

comment:6 Changed 3 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Applied to tor-browser-68.1.0esr-9.0-2 (commit e0b00a89e00e8f808c8d36e1f792e96d3d3a0f7c) and Tor Launcher's master (commit d78a233bc597c8df63e794f880a1a7f54fb9cebd).

comment:7 Changed 13 days ago by mcs

Actual Points: 1
Note: See TracTickets for help on using tickets.