Changes between Initial Version and Version 1 of Ticket #31518, comment 17


Ignore:
Timestamp:
Dec 10, 2019, 3:22:03 PM (12 months ago)
Author:
nickm
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31518, comment 17

    initial v1  
    11I'm still almost okay to merge this.  Just two issues:
    22
    3 1) "maek check" doesn't pass, because of a lintChanges issue.
     31) "make check" doesn't pass, because of a lintChanges issue.
    44
    5 2.  I'm still wondering if it's okay to do  connection_start_reading() unconditionally in  connection_or_finished_connecting().  I left a response to your response on the PR there back in Oct 25: https://github.com/torproject/tor/pull/1248#discussion_r339032153
     52)  I'm still wondering if it's okay to do  connection_start_reading() unconditionally in  connection_or_finished_connecting().  I left a response to your response on the PR there back in Oct 25: https://github.com/torproject/tor/pull/1248#discussion_r339032153
    66
    77If I get your go-ahead to fix the lintChanges issue and make the connection_start_reading() call unconditional, I will fix those, make sure CI still passes, and merge.