Opened 14 months ago

Closed 5 months ago

#31528 closed defect (fixed)

Get rid of BridgeDB's "chatspeak"

Reported by: phw Owned by: agix
Priority: Medium Milestone:
Component: Circumvention/BridgeDB Version:
Severity: Normal Keywords:
Cc: phw Actual Points: 0.5
Parent ID: #31279 Points: 1
Reviewer: Sponsor: Sponsor30-can

Description

BridgeDB's UI uses a bunch of obscure "chatspeak" references in its UI. One example is that it responds with "Uh oh, spaghettios!" if there are currently no bridges available. While funny to some, this is difficult to translate and shouldn't be part of software that's used by an international audience. Let's simplify or remove these references.

Child Tickets

Change History (17)

comment:1 Changed 7 months ago by agix

Status: newneeds_review

Changed all occurrences of 'Uh oh, spaghettios!' to just simply 'Oh no!'. No other obscure references can be found.

comment:2 Changed 7 months ago by phw

Status: needs_reviewneeds_revision

Thanks for the patch, agix! The string "Oh no!" still seems a bit silly. I suggest replacing "Oh no!" with "BridgeDB encountered an error."

Besides, there are several other occurrences that we may want to remove:

  • BridgeDB redirects assumed-to-be-malicious requests to a porn site.
  • Over here, the Web UI talks about "plain-ol'-vanilla bridges". We should at least remove the string "plain-ol'"
  • In #30941, we're improving BridgeDB's email response.

comment:3 Changed 7 months ago by agix

Status: needs_revisionneeds_review

comment:4 Changed 7 months ago by agix

I removed all occurrences of "vanilla" in the Web UI in patch 0004, since it might only confuse the user.
Internally the reference is still in use.
I also updated the dependencies in patch 0005 to be Python3 compatible.

comment:5 Changed 6 months ago by phw

Status: needs_reviewneeds_revision

Can you please make available a branch (based off of BridgeDB's develop branch) which contains your code?

You can discard 0004-Removed-or-replaced-all-chatspeak-like-strings-in-st.patch because we took care of these issues over at #30941.

Regarding 0003-Changed-redirection-to-a-classic.patch: Instead of redirecting to a video, I prefer to return an HTTP error code. Code 400 or 406 seem reasonable.

comment:7 Changed 6 months ago by agix

Status: needs_revisionneeds_review

comment:8 in reply to:  6 ; Changed 6 months ago by phw

Status: needs_reviewneeds_revision

Replying to agix:

There you go:

https://github.com/agiix/bridgedb/commit/7d421714bb79733712da7d0ca704c2209d1d2e12


The patch looks great, thanks! I left a few minor comments in the commit. Do you mind addressing them? After that, it's ready to merge.

comment:9 Changed 6 months ago by agix

Owner: set to agix
Status: needs_revisionassigned

comment:10 Changed 6 months ago by agix

Status: assignedneeds_review

comment:11 in reply to:  8 Changed 6 months ago by agix

Replying to phw:

Replying to agix:

There you go:

https://github.com/agiix/bridgedb/commit/7d421714bb79733712da7d0ca704c2209d1d2e12


The patch looks great, thanks! I left a few minor comments in the commit. Do you mind addressing them? After that, it's ready to merge.

Thanks for the feedback!
I implemented it here

comment:12 Changed 5 months ago by phw

Actual Points: 0.5
Parent ID: #31279
Resolution: fixed
Sponsor: Sponsor30-can
Status: needs_reviewclosed

Looks good to me! I merged your patch into develop after doing the following:

  • I added a CHANGELOG entry (and reduced the indentation of CHANGELOG entries to four characters).
  • I re-extracted strings to translate by running python setup.py extract_messages.
Note: See TracTickets for help on using tickets.