Opened 7 weeks ago

Closed 6 weeks ago

#31529 closed defect (fixed)

config refactoring: fix redundant reset logic

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: network-team-roadmap-august, asn-merge, dgoulet-merge
Cc: nickm, teor, gaba Actual Points: 0
Parent ID: #29211 Points: 0
Reviewer: Sponsor: Sponsor31-can

Description

We have this block in our code now:

    // XXXX This is unreachable, since a CLEAR line always has an
    // XXXX empty value.
    config_reset(mgr, options, mvar, use_defaults); // LCOV_EXCL_LINE

We should fix it by changing it to a nonfatal assertion.

Child Tickets

Change History (5)

comment:1 Changed 6 weeks ago by nickm

Actual Points: 0

Branch is ticket31529; PR in https://github.com/torproject/tor/pull/1292 .

I'll make this needs_review once CI has passed.

comment:2 Changed 6 weeks ago by nickm

Status: assignedneeds_review

comment:3 Changed 6 weeks ago by teor

Status: needs_reviewmerge_ready

Looks fine to me.

comment:4 Changed 6 weeks ago by teor

Keywords: asn-merge dgoulet-merge added

There might be some minor merge conflicts with these tickets, feel free to put back in needs_revision, or ask nickm how to fix the conflict.

comment:5 Changed 6 weeks ago by asn

Resolution: fixed
Status: merge_readyclosed

Merged! No conflicts encountered.

Note: See TracTickets for help on using tickets.