snowflake.tp.o could use a favicon

added component::circumvention/snowflake priority::medium resolution::fixed reviewer::cohosh severity::normal status::closed type::defect labels

Here's a patch to add a favicon (same one as on this trac page),

https://github.com/keroserene/snowflake/commit/d2efb76231f1f20136f7d5880f9a737be418aa3a

Note that, at present, the main www.tp.o page doesn't even have one :)

Trac:
Status: new to needs_review

Trac:
Reviewer: N/A to cohosh

Heh, I hadn't noticed tp.o doesn't have one.

Looks good to me. This is also related to #19774 (moved), we could keep an eye on that and think about whether we want a similar favicon for all our circumvention stuff.

Trac:
Status: needs_review to merge_ready

Merged as https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=a5071ec1d623182eb2d9bc36f033f0990f50ec6f

For what it's worth, I went an onion instead of a snowflake here because I was concerned that there might be some confusion with the extension's toolbar icon.

However, maybe it's worth adding a snowflake favicon to https://snowflake.torproject.org/embed.html that gets updated with state, similar to the extension's browserAction.setIcon, so that you can use a pinned tab in situations where installing an extension is not feasible.

However, maybe it's worth adding a snowflake favicon to ​https://snowflake.torproject.org/embed.html that gets updated with state, similar to the extension's browserAction.setIcon, so that you can use a pinned tab in situations where installing an extension is not feasible.

Here's a patch for that if you like the idea, https://github.com/keroserene/snowflake/commit/621fc59dc6e7548420806dd29f1c4813e5e47009

Replying to arlolra:

However, maybe it's worth adding a snowflake favicon to ​https://snowflake.torproject.org/embed.html that gets updated with state, similar to the extension's browserAction.setIcon, so that you can use a pinned tab in situations where installing an extension is not feasible.

Here's a patch for that if you like the idea, https://github.com/keroserene/snowflake/commit/621fc59dc6e7548420806dd29f1c4813e5e47009

375 KB seems big for a favicon; maybe it's better to use a single PNG and let the browser resize it, rather than have all the sizes precomputed in the ICO file. The 256×256 PNG is 87 KB and the 128×128 is 10 KB.

375 KB seems big for a favicon;

Yikes, thanks for catching that.

I added a second commit to the branch to reduce those sizes by restricting to icon:auto-resize=32.

https://github.com/keroserene/snowflake/commits/trac31537

Trac:
Status: merge_ready to needs_review

Works for me.

Trac:
Status: needs_review to merge_ready

Merged as https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=faf02d86a15c795e69f176d952bbe1f3f531da28 and https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=d8d3170af8ad0a370ca8c83f996c6c7ff2836076

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

moved to tpo/anti-censorship/pluggable-transports/snowflake#31537 (closed)