Opened 9 months ago

Closed 8 months ago

#31537 closed defect (fixed)

snowflake.tp.o could use a favicon

Reported by: cypherpunks Owned by:
Priority: Medium Milestone:
Component: Circumvention/Snowflake Version:
Severity: Normal Keywords:
Cc: arlolra, cohosh, phw, dcf Actual Points:
Parent ID: Points:
Reviewer: cohosh Sponsor:

Description


Child Tickets

Change History (10)

comment:1 Changed 8 months ago by arlolra

Status: newneeds_review

Here's a patch to add a favicon (same one as on this trac page),

https://github.com/keroserene/snowflake/commit/d2efb76231f1f20136f7d5880f9a737be418aa3a

Note that, at present, the main www.tp.o page doesn't even have one :)

comment:2 Changed 8 months ago by cohosh

Reviewer: cohosh

comment:3 Changed 8 months ago by cohosh

Status: needs_reviewmerge_ready

Heh, I hadn't noticed tp.o doesn't have one.

Looks good to me. This is also related to #19774, we could keep an eye on that and think about whether we want a similar favicon for all our circumvention stuff.

comment:4 Changed 8 months ago by arlolra

Merged as https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=a5071ec1d623182eb2d9bc36f033f0990f50ec6f

For what it's worth, I went an onion instead of a snowflake here because I was concerned that there might be some confusion with the extension's toolbar icon.

However, maybe it's worth adding a snowflake favicon to https://snowflake.torproject.org/embed.html that gets updated with state, similar to the extension's browserAction.setIcon, so that you can use a pinned tab in situations where installing an extension is not feasible.

comment:5 Changed 8 months ago by arlolra

However, maybe it's worth adding a snowflake favicon to ​https://snowflake.torproject.org/embed.html that gets updated with state, similar to the extension's browserAction.setIcon, so that you can use a pinned tab in situations where installing an extension is not feasible.

Here's a patch for that if you like the idea,
https://github.com/keroserene/snowflake/commit/621fc59dc6e7548420806dd29f1c4813e5e47009

comment:6 in reply to:  5 Changed 8 months ago by dcf

Replying to arlolra:

However, maybe it's worth adding a snowflake favicon to ​https://snowflake.torproject.org/embed.html that gets updated with state, similar to the extension's browserAction.setIcon, so that you can use a pinned tab in situations where installing an extension is not feasible.

Here's a patch for that if you like the idea,
https://github.com/keroserene/snowflake/commit/621fc59dc6e7548420806dd29f1c4813e5e47009

375 KB seems big for a favicon; maybe it's better to use a single PNG and let the browser resize it, rather than have all the sizes precomputed in the ICO file. The 256×256 PNG is 87 KB and the 128×128 is 10 KB.

comment:7 Changed 8 months ago by arlolra

375 KB seems big for a favicon;

Yikes, thanks for catching that.

I added a second commit to the branch to reduce those sizes by restricting to icon:auto-resize=32.

https://github.com/keroserene/snowflake/commits/trac31537

comment:8 Changed 8 months ago by arlolra

Status: merge_readyneeds_review

comment:9 Changed 8 months ago by dcf

Status: needs_reviewmerge_ready

Works for me.

Note: See TracTickets for help on using tickets.