Opened 4 months ago

Last modified 3 months ago

#31544 assigned defect

sr: Check why some sr_disk_state fields need to be cleared

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: network-team-roadmap-august, 042-deferred-20190918
Cc: nickm, teor, gaba Actual Points:
Parent ID: #29211 Points:
Reviewer: Sponsor:

Description

Split off #31240:

teor: When we add fields, how will we make sure we remember to clear them all?

nickm: We don't need to do so in general, the manager will take care of it for us. This is only necessary for derived fields, and fields for which the unit tests are expecting an unusual behavior, IIRC.

nickm: (I can dig deeper here; I forget the exact reason why this function is clearing these, but I think it is because of legacy cruft.)

teor: Yeah let's double-check what's going on here.

https://github.com/nmathewson/tor/pull/3#discussion_r317548828

Child Tickets

Change History (1)

comment:1 Changed 3 months ago by nickm

Keywords: 042-deferred-20190918 added
Milestone: Tor: 0.4.2.x-finalTor: unspecified

Deferring various tickets from 0.4.2 to Unspecified.

Note: See TracTickets for help on using tickets.