Opened 7 weeks ago

Last modified 3 weeks ago

#31546 new enhancement

Create and expose PDB files for Tor Browser debugging on Windows

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm
Cc: tom Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Now that we are about to use mingw-w64-clang for the Firefox part in Tor Browser we are able to get PDB files for debugging. We should make sure they show up after the build and probably expose them (at least the 64bit ones) similarly to the Linux debug symbols to aid in debugging Windows issues.

Child Tickets

Change History (4)

comment:1 Changed 5 weeks ago by gk

https://bugzilla.mozilla.org/show_bug.cgi?id=1475562 is the bug. As tjr said, it's probably just a matter of setting export MOZ_COPY_PDBS=1 and then bundle them up properly.

That should give us debug info for almost all involved pieces. However, the libc++.a is still missing in that case as we omit debug information there. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1500102 for details (we ship those builds, thus we might want to have special debug builds for that in a follow-up bug, not sure).

comment:2 Changed 4 weeks ago by cypherpunks

However, the libc++.a is still missing in that case as we omit debug information there.

Make it dynamic?

thus we might want to have special debug builds for that in a follow-up bug

Well-known as ASAN Win64.

comment:3 Changed 3 weeks ago by gk

Cc: tom added

Hm, only the .pdb files for the .exe files show up if I do an export MOZ_COPY_PDBS=1. Looking at the build results I can see, though, that there *are* .pdb files for the .dlls as well but they are not getting included in the dist/firefox dir which we use for bundling up the build results.

comment:4 Changed 3 weeks ago by tom

Hm. Is it possible that they are symlinked into dist/firefox and not making it into an output archive?

Could you get me a --verbose build log that I could look at to see if I can notice anything?

Note: See TracTickets for help on using tickets.