Opened 3 months ago

Closed 3 months ago

Last modified 8 weeks ago

#31547 closed task (fixed)

Back out or modify patches for Mozilla's bug 1574980

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201908, tbb-update
Cc: mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The patches for bug 1574980 fix a security flaw in dealing with the maintenance service on Windows. We don't use that one, so we should be not affected. However, the way the fix was written is that it drags maintenance service related code into the general updater code: we build that now, too, which was not the case before. We don't want and need that and should either back out the whole patches (both for esr60 and esr68) or come up with a better solution.

I guess due to time constraints we follow the former idea and try to write better patches later on (and get those upstreamed).

Child Tickets

Change History (3)

comment:2 Changed 3 months ago by gk

Resolution: fixed
Status: newclosed

Reverted with commit d8983a79f8a0e9ae4543c229819cd17ee0e3f78a (tor-browser-68.1.0esr-9.0-1) and commit 04bfd4217d0faaf42ad5338d6a6925b840059d29 (tor-browser-60.9.0esr-8.5-2). mcs/brade: What's the plan here? Do we want to file a bug in bugzilla to get this properly fixed upstream? If so, could you do so and link to it in this ticket?

comment:3 in reply to:  2 Changed 8 weeks ago by mcs

Replying to gk:

mcs/brade: What's the plan here? Do we want to file a bug in bugzilla to get this properly fixed upstream? If so, could you do so and link to it in this ticket?

Kathy and I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1588549

Note: See TracTickets for help on using tickets.