hs-v3: Service can keep unused intro points in its list
Tor always selects an extra number of intro points in addition to the configured HiddenServiceNumIntroductionPoints
.
It launches all of them and the first NumIntro...
to finish are used (considering #31548 (moved) is resolved).
Once the circuit of the remaining intro opens, we notice that we have too many and then re-purpose the extra ones.
However, I've noticed that sometimes establishing an intro circuit timeouts during build, basically expiring due to our CBT policy. In that case, the circuit is simply close but the intro point remains in the service descriptor list.
This is bad because of #31548 (moved), this means an intro point can end up in the descriptor even though the service never established any circuits to it...
We simply need to callback into the HS subsystem when we are expiring an HS circuit so appropriate actions can be taken such as in this case, removing the IP from the list.