Opened 7 weeks ago

Last modified 4 weeks ago

#31576 new defect

Fix shellcheck errors in contrib/dist/rc.subr, and add to test-shellcheck

Reported by: teor Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Minor Keywords: shellcheck
Cc: nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This would be nice to have, but it's not urgent at all.

Child Tickets

TicketStatusOwnerSummaryComponent
#30797newStop shipping an abandoned systemd script?Core Tor/Tor

Change History (6)

comment:1 Changed 5 weeks ago by rl1987

Should we perhaps remove it instead? It was added in #256 back in 2006, and seems to be last updated in 2008.

comment:2 Changed 5 weeks ago by teor

Cc: nickm added

Good question: I don't know if anyone is still using it.

Cc'ing nickm, who has done similar removals recently.

comment:3 Changed 5 weeks ago by nickm

Hm. I think this one is probably safe to remove: it has decorations indicating that it came from FreeBSD's CVS repository, which suggests to me that the FreeBSD people are probably maintaining their own version.

There are other scripts of this kind, however. Maybe we should sent a message to the tor-packagers list, asking if anybody is currently using any of the init scripts from our repository? If we find that some are in use, we can decide whether to keep them or to give other projects responsibility for them.

comment:4 in reply to:  3 Changed 4 weeks ago by teor

Replying to nickm:

Hm. I think this one is probably safe to remove: it has decorations indicating that it came from FreeBSD's CVS repository, which suggests to me that the FreeBSD people are probably maintaining their own version.

+1

There are other scripts of this kind, however. Maybe we should sent a message to the tor-packagers list, asking if anybody is currently using any of the init scripts from our repository? If we find that some are in use, we can decide whether to keep them or to give other projects responsibility for them.

I tried looking for these other scripts, and I could only find:

  • contrib/dist
    • rc.subr - script
    • tor.service.in - systemd service ini file

Do you want me to ask tor-packagers about these two files?
Or are there other files you are thinking of?

comment:5 in reply to:  3 Changed 4 weeks ago by arma

Replying to nickm:

Maybe we should sent a message to the tor-packagers list, asking if anybody is currently using any of the init scripts from our repository?

See also #30797. I'm not sure what the right outcome should be, but the discussions there seem very related to this question.

comment:6 Changed 4 weeks ago by teor

Ok, I'll ask about both unmaintained service files:

  • contrib/dist
    • rc.subr - script
    • tor.service.in - systemd service ini file
Note: See TracTickets for help on using tickets.