Remove/stop shipping contrib/dist/rc.subr

It appears FreeBSD no longer needs it.

changed milestone to %Tor: 0.4.4.x-final

added component::core tor/tor milestone::Tor: 0.4.4.x-final priority::low resolution::fixed reviewer::dgoulet severity::minor status::closed type::defect labels

Should we perhaps remove it instead? It was added in #256 (moved) back in 2006, and seems to be last updated in 2008.

Good question: I don't know if anyone is still using it.

Cc'ing nickm, who has done similar removals recently.

Trac:
Cc: N/A to nickm

Hm. I think this one is probably safe to remove: it has decorations indicating that it came from FreeBSD's CVS repository, which suggests to me that the FreeBSD people are probably maintaining their own version.

There are other scripts of this kind, however. Maybe we should sent a message to the tor-packagers list, asking if anybody is currently using any of the init scripts from our repository? If we find that some are in use, we can decide whether to keep them or to give other projects responsibility for them.

Replying to nickm:

Hm. I think this one is probably safe to remove: it has decorations indicating that it came from FreeBSD's CVS repository, which suggests to me that the FreeBSD people are probably maintaining their own version.

+1

There are other scripts of this kind, however. Maybe we should sent a message to the tor-packagers list, asking if anybody is currently using any of the init scripts from our repository? If we find that some are in use, we can decide whether to keep them or to give other projects responsibility for them.

I tried looking for these other scripts, and I could only find:

• contrib/dist
  • rc.subr - script
  • tor.service.in - systemd service ini file

Do you want me to ask tor-packagers about these two files? Or are there other files you are thinking of?

Replying to nickm:

Maybe we should sent a message to the tor-packagers list, asking if anybody is currently using any of the init scripts from our repository?

See also #30797 (moved). I'm not sure what the right outcome should be, but the discussions there seem very related to this question.

Ok, I'll ask about both unmaintained service files:

• contrib/dist
  • rc.subr - script
  • tor.service.in - systemd service ini file

Do we have any answer?

I'm sorry, I forgot to ask.

Here's the thread I just started on the packagers mailing list: https://lists.torproject.org/pipermail/tor-packagers/2020-January/000082.html

Trac:
Description: This would be nice to have, but it's not urgent at all.

to

It appears FreeBSD no longer needs it.
Summary: Fix shellcheck errors in contrib/dist/rc.subr, and add to test-shellcheck to Remove/stop shipping contrib/dist/rc.subr
Keywords: shellcheck deleted, N/A added

https://github.com/torproject/tor/pull/1690

Trac:
Status: new to needs_review

Trac:
Milestone: Tor: unspecified to Tor: 0.4.4.x-final

lgtm; Holding up on merge until 044 merge window opens.

Trac:
Status: needs_review to merge_ready
Reviewer: N/A to dgoulet

merged to master. What shall we do with the child tickets, so we can close this one?

I made some notes on the child ticket: let's wait a little longer, then wontfix it.

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

moved to tpo/core/tor#31576 (closed)