Opened 14 months ago

Closed 8 months ago

#31576 closed defect (fixed)

Remove/stop shipping contrib/dist/rc.subr

Reported by: teor Owned by:
Priority: Low Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords:
Cc: nickm Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description (last modified by rl1987)

It appears FreeBSD no longer needs it.

Child Tickets

Change History (14)

comment:1 Changed 13 months ago by rl1987

Should we perhaps remove it instead? It was added in #256 back in 2006, and seems to be last updated in 2008.

comment:2 Changed 13 months ago by teor

Cc: nickm added

Good question: I don't know if anyone is still using it.

Cc'ing nickm, who has done similar removals recently.

comment:3 Changed 13 months ago by nickm

Hm. I think this one is probably safe to remove: it has decorations indicating that it came from FreeBSD's CVS repository, which suggests to me that the FreeBSD people are probably maintaining their own version.

There are other scripts of this kind, however. Maybe we should sent a message to the tor-packagers list, asking if anybody is currently using any of the init scripts from our repository? If we find that some are in use, we can decide whether to keep them or to give other projects responsibility for them.

comment:4 in reply to:  3 Changed 13 months ago by teor

Replying to nickm:

Hm. I think this one is probably safe to remove: it has decorations indicating that it came from FreeBSD's CVS repository, which suggests to me that the FreeBSD people are probably maintaining their own version.

+1

There are other scripts of this kind, however. Maybe we should sent a message to the tor-packagers list, asking if anybody is currently using any of the init scripts from our repository? If we find that some are in use, we can decide whether to keep them or to give other projects responsibility for them.

I tried looking for these other scripts, and I could only find:

  • contrib/dist
    • rc.subr - script
    • tor.service.in - systemd service ini file

Do you want me to ask tor-packagers about these two files?
Or are there other files you are thinking of?

comment:5 in reply to:  3 Changed 13 months ago by arma

Replying to nickm:

Maybe we should sent a message to the tor-packagers list, asking if anybody is currently using any of the init scripts from our repository?

See also #30797. I'm not sure what the right outcome should be, but the discussions there seem very related to this question.

comment:6 Changed 13 months ago by teor

Ok, I'll ask about both unmaintained service files:

  • contrib/dist
    • rc.subr - script
    • tor.service.in - systemd service ini file

comment:7 Changed 9 months ago by rl1987

Do we have any answer?

comment:8 Changed 9 months ago by teor

I'm sorry, I forgot to ask.

Here's the thread I just started on the packagers mailing list:
https://lists.torproject.org/pipermail/tor-packagers/2020-January/000082.html

comment:9 Changed 9 months ago by rl1987

Description: modified (diff)
Keywords: shellcheck removed
Summary: Fix shellcheck errors in contrib/dist/rc.subr, and add to test-shellcheckRemove/stop shipping contrib/dist/rc.subr

comment:10 Changed 9 months ago by rl1987

Status: newneeds_review

comment:11 Changed 9 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.4.4.x-final

comment:12 Changed 9 months ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready

lgtm; Holding up on merge until 044 merge window opens.

comment:13 Changed 8 months ago by nickm

merged to master. What shall we do with the child tickets, so we can close this one?

comment:14 Changed 8 months ago by teor

Resolution: fixed
Status: merge_readyclosed

I made some notes on the child ticket: let's wait a little longer, then wontfix it.

Note: See TracTickets for help on using tickets.