Opened 6 weeks ago

Closed 6 weeks ago

Last modified 2 weeks ago

#31592 closed defect (fixed)

9.0a6 alpha build breaks in mobile `stage-package` step

Reported by: gk Owned by: tbb-team
Priority: Immediate Milestone:
Component: Applications/Tor Browser Version:
Severity: Blocker Keywords: TorBrowserTeam201909, tbb-9.0-must-alpha
Cc: sisbell, boklm, sysrqb, acat Actual Points: 0.1
Parent ID: Points:
Reviewer: Sponsor:

Description

Our nightly builds are good but for some reason our alpha build breaks in the mobile packaging step:

 0:00.29 make[1]: Entering directory '/var/tmp/build/firefox-262c4677852f/obj-arm-linux-androideabi/mobile/android/installer'
 0:00.71 Warning: $SRCDIR/mobile/android/installer/package-manifest.in:96: Missing file(s): bin/blocklist.xml
 0:00.72 Warning: $SRCDIR/mobile/android/installer/package-manifest.in:101: Missing file(s): bin/components/components.manifest
 0:02.41 Warning: $SRCDIR/mobile/android/installer/package-manifest.in:174: Missing file(s): bin/defaults/pref/channel-prefs.js
 0:02.46 Traceback (most recent call last):
 0:02.46   File "/var/tmp/build/firefox-262c4677852f/toolkit/mozapps/installer/packager.py", line 347, in <module>
 0:02.46     main()
 0:02.46   File "/var/tmp/build/firefox-262c4677852f/toolkit/mozapps/installer/packager.py", line 287, in main
 0:02.46     preprocess_manifest(sink, args.manifest, defines)
 0:02.47   File "/var/tmp/build/firefox-262c4677852f/python/mozbuild/mozpack/packager/__init__.py", line 215, in preprocess_manifest
 0:02.47     preprocess(manifest, PackageManifestParser(sink), defines)
 0:02.47   File "/var/tmp/build/firefox-262c4677852f/python/mozbuild/mozpack/packager/__init__.py", line 206, in preprocess
 0:02.47     pp.do_include(input)
 0:02.47   File "/var/tmp/build/firefox-262c4677852f/python/mozbuild/mozbuild/preprocessor.py", line 800, in do_include
 0:02.47     self.handleLine(l)
 0:02.47   File "/var/tmp/build/firefox-262c4677852f/python/mozbuild/mozbuild/preprocessor.py", line 571, in handleLine
 0:02.47     self.write(aLine)
 0:02.47   File "/var/tmp/build/firefox-262c4677852f/python/mozbuild/mozbuild/preprocessor.py", line 452, in write
 0:02.47     filteredLine = self.applyFilters(aLine)
 0:02.47   File "/var/tmp/build/firefox-262c4677852f/python/mozbuild/mozbuild/preprocessor.py", line 427, in applyFilters
 0:02.47     aLine = f[1](aLine)
 0:02.47   File "/var/tmp/build/firefox-262c4677852f/python/mozbuild/mozbuild/preprocessor.py", line 749, in filter_substitution
 0:02.47     return self.varsubst.sub(repl, aLine)
 0:02.47   File "/var/tmp/build/firefox-262c4677852f/python/mozbuild/mozbuild/preprocessor.py", line 747, in repl
 0:02.47     raise Preprocessor.Error(self, 'UNDEFINED_VAR', varname)
 0:02.47 mozbuild.preprocessor.Error: ('$SRCDIR/mobile/android/installer/package-manifest.in', 206, 'UNDEFINED_VAR', 'RESPATH')
 0:02.48 /var/tmp/build/firefox-262c4677852f/toolkit/mozapps/installer/packager.mk:23: recipe for target 'stage-package' failed
 0:02.48 make[1]: *** [stage-package] Error 1

Child Tickets

Change History (4)

comment:1 Changed 6 weeks ago by gk

Cc: acat added

Likely coming from #30683.

comment:2 Changed 6 weeks ago by acat

Status: newneeds_review

Sorry, I updated #30683 instead of this one with the fixup. It's in https://github.com/acatarineu/tor-browser/commit/30683_esr68+2.

comment:3 Changed 6 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Cherry-picked to tor-browser-68.1.0esr-9.0-2 (commit 80f3dafdd420491e23c22a688d075548480f78a6).

comment:4 Changed 2 weeks ago by acat

Actual Points: 0.1
Note: See TracTickets for help on using tickets.