Opened 2 months ago

Closed 5 weeks ago

#31602 closed task (fixed)

Remove Pocket indicators in UI and disable it by default

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff68-esr, tbb-9.0-must, TorBrowserTeam201910R
Cc: Actual Points: 0.1
Parent ID: Points: 0.25
Reviewer: Sponsor:

Description

We should look at disabling Pocket as it is now integrated into Firefox directly. Might be enough just flipping extensions.pocket.enabled`.

(FPI might actually break the Pocket login flow and Mozilla recommends disabling it, so that it probably reason enough to disabled Pocket for the time being: https://help.getpocket.com/article/1046-trouble-saving-to-pocket-stuck-in-a-loop)

Child Tickets

Change History (9)

comment:1 Changed 2 months ago by gk

Points: 0.25

comment:2 Changed 2 months ago by Thorin

AFAIK ... FPI & Pocket was fixed in FF66: https://bugzilla.mozilla.org/show_bug.cgi?id=1384657

comment:3 in reply to:  2 Changed 2 months ago by gk

Replying to Thorin:

AFAIK ... FPI & Pocket was fixed in FF66: https://bugzilla.mozilla.org/show_bug.cgi?id=1384657

Could be, but the scary page still exists.

comment:4 Changed 2 months ago by Thorin

What scary page? Edit: not saying we shouldn't disable Pocket in TB, I think we should. Just saying that the FPI thing is sorted. As long as you don't have/load AS (activity stream), then the pref is enough in my experience

Last edited 2 months ago by Thorin (previous) (diff)

comment:5 Changed 6 weeks ago by gk

Keywords: tbb-9.0-must added

comment:6 Changed 6 weeks ago by pili

Keywords: TorBrowserTeam201910 added

comment:7 Changed 6 weeks ago by pili

Keywords: TorBrowserTeam201909 removed

comment:8 Changed 5 weeks ago by acat

Actual Points: 0.1
Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: newneeds_review

For review: https://github.com/acatarineu/tor-browser/commit/31602

I think we are good with the pref flip. about:pocket-saved and about:pocket-signup are still accessible, but harmless (and broken).

comment:9 Changed 5 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Cherry-picked to tor-browser-68.1.0esr-9.0-2 (commit 72c1885e368f0544a66a68e3b8a16085cd40c323) and mentioning the bug number in the commit message.

Note: See TracTickets for help on using tickets.