Opened 2 weeks ago

Last modified 21 hours ago

#31607 new defect

App menu items stop working

Reported by: mcs Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909
Cc: acat Actual Points:
Parent ID: Points: 0.5
Reviewer: Sponsor:

Description

In the ESR68-based Tor Browser on macOS, the App menu items are not working. For example, choosing Quit or pressing Cmd+Q has no effect. Same for Preferences and Cmd+,

I observed this problem while testing the es-ES and en-US builds from the following location on an older macOS 10.11.6 system:
https://people.torproject.org/~gk/builds/9.0a6-build4/

I will re-test on a 10.14.x system to make sure it isn't specific to macOS 10.11.x.

Child Tickets

Change History (8)

comment:1 Changed 2 weeks ago by mcs

A little more testing shows that About Tor Browser never works, but items like Preferences do work at first but stop after you try to access About Tor Browser. I saw the same behavior on macOS 10.14.x.

comment:2 Changed 2 weeks ago by mcs

Summary: App menu items not workingApp menu items stop working

comment:3 Changed 2 weeks ago by cypherpunks

Cc: ff68-esr, tbb-9.0-must-alpha?

comment:4 in reply to:  3 Changed 2 weeks ago by mcs

Cc: ff68-esr tbb-9.0-must-alpha removed
Keywords: ff68-esr tbb-9.0-must-alpha added

Replying to cypherpunks:

Cc: ff68-esr, tbb-9.0-must-alpha?

Thanks and fixed.

comment:5 Changed 2 weeks ago by gk

Cc: acat added
Keywords: TorBrowserTeam201909 added
Points: 0.5

Do we get any errors in the error console? I wonder whether we made a mistake when integrating the About dialog from Torbutton directly into tor-browser.

comment:6 in reply to:  5 Changed 8 days ago by mcs

Replying to gk:

Do we get any errors in the error console? I wonder whether we made a mistake when integrating the About dialog from Torbutton directly into tor-browser.

When I choose "About Tor Browser" from the app menu the error console shows:

NS_ERROR_NOT_AVAILABLE: utilityOverlay.js:994

That line in utilityOverlay.js is:

 window.openDialog("chrome://browser/content/aboutDialog.xul", "", features);

If I enter chrome://browser/content/aboutDialog.xul in the URL bar, the about box XUL loads in a regular tab. Kathy and I will look deeper.

Last edited 8 days ago by mcs (previous) (diff)

comment:7 Changed 32 hours ago by mcs

Here is some more info:

  • This bug does not occur if the modal Tor Launcher window is not opened at startup.
  • The menu items stop working because the underlying C++ and Objective-C menu objects are destroyed.

Kathy and I will continue to debug this.

comment:8 Changed 21 hours ago by mcs

A quick update: this bug occurs without any of our Tor Browser patches. Specifically, I checked out revision a37fc1d6835dcebc36ae80f1d81f06d7807988b4 and then applied the #28044 patch (e05db1ef99bf1fa0717e357d7359ab6f7104a8c6). It is easy to reproduce this bug by starting with TOR_FORCE_NET_CONFIG=1, clicking "Connect", and then hitting Cmd+, (which should open the about:preferences but does not).

Note: See TracTickets for help on using tickets.