Reorder the early subsystems based on their dependencies

Some of our subsystem dependencies are out of sync with their module dependencies.

So if these early subsystems log, we might not be able to see the errors. (Or the process might crash.)

changed milestone to %Tor: 0.4.2.x-final

added 040-no-backport 041-no-backport 042-should BugSmashFund actualpoints::0.3 component::core tor/tor consider-backport-after-042-stable consider-backport-if-needed dgoulet-merge diagnostics milestone::Tor: 0.4.2.x-final owner::teor points::0.2 priority::medium resolution::fixed reviewer::nickm severity::normal status::closed type::defect version::tor 0.4.0.1-alpha labels

Possibly helpful: you can run ./scripts/maint/practracker/includes.py --toposort to get the modules covered by .may_include, topologically sorted by which other modules they depend on.

Replying to nickm:

Possibly helpful: you can run ./scripts/maint/practracker/includes.py --toposort to get the modules covered by .may_include, topologically sorted by which other modules they depend on.

Hmm, so there's another check that practracker could do: make sure the subsystem init order corresponds to the topological sort order,

Yeah -- I think in this case what we want to do might be to make a debugging command for tor to dump the subsystem init order, so we don't need to parse it out of the source.

Yeah and we can't parse it out of the logs, because the buggy module order was in modules that were initialised before the logs.

I opened #31634 (moved) for that change. It's a big one, so I'm not going to do anything about it now.

See my pull request:

• 0.3.5: ​https://github.com/torproject/tor/pull/1301

The merge forward was clean.

Here are the test branches for merging forwards:

• ​https://github.com/teor2345/tor/branches/all?query=bug31615_

Trac:
Description: Part of #31594 (moved).

to

Some of our subsystem dependencies are out of sync with their module dependencies.

So if these early subsystems log, we might not be able to see the errors. (Or the process might crash.)
Version: N/A to Tor: 0.4.0.1-alpha
Points: N/A to 0.2
Cc: gaba to N/A
Keywords: android, 035-backport, macos deleted, BugSmash added
Status: new to needs_review
Actualpoints: N/A to 0.2

Trac:
Keywords: 041-backport, 040-backport deleted, 040-backport-maybe, 041-backport-maybe added

I don't think we should backport this fix, unless the bug is actually causing issues in older versions.

Trac:
Keywords: N/A deleted, consider-backport-after-042-stable, consider-backport-if-needed added

Trac:
Owner: N/A to teor
Status: needs_review to assigned

Trac:
Status: assigned to needs_review

Fix bug smash fund spelling

Trac:
Keywords: BugSmash deleted, BugSmashFund added

Trac:
Reviewer: N/A to nickm

These look good, except that the levels we have here are now out-of-sync with the comments in tor_subsystems.c. Please feel free to either edit the ones in tor_subsystems.c, or remove them entirely, and put this back into merge_ready once you've done so.

Trac:
Status: needs_review to needs_revision

This ticket is independent of its parent.

Trac:
Parent: #31594 (moved) to N/A

I removed the comments, the merge forward had trivial conflicts:

• 0.4.0: https://github.com/torproject/tor/pull/1301
• 0.4.1: https://github.com/torproject/tor/pull/1310
• master: https://github.com/torproject/tor/pull/1311

CI is still running on 0.4.1 and master, but I only changed comments, so I think it will pass.

Trac:
Actualpoints: 0.2 to 0.3
Status: needs_revision to merge_ready

(CI has passed)

Trac:
Keywords: N/A deleted, dgoulet-merge added

Merged to master. Moving to 041 milestone for backport.

Trac:
Milestone: Tor: 0.4.2.x-final to Tor: 0.4.1.x-final

I suggest no backport here; please reopen if you disagree. The misordering in 0.4.1 isn't actually hurting anything FWICT.

Trac:
Resolution: N/A to fixed
Milestone: Tor: 0.4.1.x-final to Tor: 0.4.2.x-final
Status: merge_ready to closed

Trac:
Keywords: 040-backport-maybe, 041-backport-maybe deleted, 041-no-backport, 040-no-backport added

closed

changed time estimate to 1h 36m

added 2h 24m of time spent

mentioned in issue #31634 (moved)

moved to tpo/core/tor#31615 (closed)

mentioned in issue tpo/core/tor#31634 (closed)