Opened 6 weeks ago

Closed 5 weeks ago

Last modified 5 weeks ago

#31621 closed defect (fixed)

Fix node bug that makes large writes to stdout fail

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909R, GeorgKoppen201909
Cc: boklm Actual Points: 0.25
Parent ID: #31538 Points: 0.25
Reviewer: Sponsor:

Description

We wallpapered around a node bug that breaks compilation in case large writes are made to stdout (see: comment:7:ticket:30321 for context). This is biting us in cases where we actually *do* need those large write to debug problems like in #31538.

We should provide a better fix/workaround.

Child Tickets

Change History (4)

comment:2 in reply to:  1 ; Changed 6 weeks ago by gk

Keywords: TorBrowserTeam201909R added; TorBrowserTeam201909 removed
Status: newneeds_review

comment:3 in reply to:  2 Changed 5 weeks ago by boklm

Resolution: fixed
Status: needs_reviewclosed

Replying to gk:

Thanks! That saved me some hours of work. bug_31621 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_31621&id=a81c439b3f490c75e0abf5a52de7927e09c3c4f5) in my tor-browser repo and bug_31621 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_31621&id=5648e1499c10d2565e2cd9ca23599b532df8cff4) in my tor-browser-build one have the patches for review.

This looks good to me. I cherry-picked the tor-browser patch to branch tor-browser-68.1.0esr-9.0-2 as commit 4458b4e8a09aaa759f1735b36aec860aa61f3ba7, and merged the tor-browser-build patch to master with commit f08dbd57ed76faa08007608130da50c4f80a9d64.

comment:4 Changed 5 weeks ago by gk

Actual Points: 0.25
Note: See TracTickets for help on using tickets.