Opened 6 weeks ago

Closed 5 weeks ago

#31626 closed enhancement (fixed)

Move confparse.[ch] into lib/confmgt

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 042-should dgoulet-merge
Cc: nickm, teor, gaba Actual Points: .1
Parent ID: #29211 Points: 0
Reviewer: teor Sponsor: Sponsor31-can

Description

This should now be a simple task, since confparse.[ch] no longer depends on anything higher-level than lib. But it will conflict with other things, so we should do it at some point when there are not other pending commits.

Child Tickets

Change History (9)

comment:1 Changed 6 weeks ago by nickm

Type: defectenhancement

Mark a number of current 0.4.2.x "defects" as "enhancements."

comment:2 Changed 5 weeks ago by nickm

Mark some assigned tickets as 042-should.

comment:3 Changed 5 weeks ago by nickm

Keywords: 042-should added

comment:4 Changed 5 weeks ago by nickm

Branch is ticket31626; PR at https://github.com/torproject/tor/pull/1319 . I'll wait for CI to pass before I put this in needs_review.

comment:5 Changed 5 weeks ago by nickm

Actual Points: .1
Reviewer: teor
Status: assignedneeds_review

CI has passed.

comment:6 Changed 5 weeks ago by teor

Status: needs_reviewneeds_revision

We also rectified some unrelated include paths in this patch.
I'm ok with that.
But if you want to put them in a separate commit, that might be nice.

Feel free to put this ticket in merge_ready if you don't think that's worth the effort.

comment:7 Changed 5 weeks ago by teor

Let's avoid issues like this in future, by implementing #31713.

comment:8 Changed 5 weeks ago by nickm

Keywords: dgoulet-merge added
Status: needs_revisionmerge_ready

We also rectified some unrelated include paths in this patch.
I'm ok with that.
But if you want to put them in a separate commit, that might be nice.

I think I'd rather leave them in a single commit -- IMO splitting it up loses some of the point of having these commits be automatically generated.

comment:9 Changed 5 weeks ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.