Opened 13 days ago

Last modified 9 days ago

#31634 new enhancement

Check .may_include order and tor subsystem init order are compatible

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: diagnostics, 042-should, practracker
Cc: gaba Actual Points:
Parent ID: Points: 2
Reviewer: Sponsor: Sponsor31-can

Description

In #31615, we discovered that our module init order doesn't match their dependency order.

Let's use practracker and tor to make sure that doesn't happen again. We'll probably need a new make check target, because we'll need a compiled tor and practracker output. See #31615 for details.

Gaba, this is Sponsor 31-can, because it helps us catch refactoring bugs when we create new modules.

Child Tickets

Change History (5)

comment:1 Changed 13 days ago by teor

We might also want to check against the order in subsystem_list.c.

comment:2 in reply to:  1 ; Changed 13 days ago by nickm

Replying to teor:

We might also want to check against the order in subsystem_list.c.

Yes, but have a look at check_and_setup() in subsysmgr.c -- that causes tor to exit with an assertion failure on startup if the subsystems are not sorted by priority.

comment:3 in reply to:  2 Changed 13 days ago by teor

Replying to nickm:

Replying to teor:

We might also want to check against the order in subsystem_list.c.

Yes, but have a look at check_and_setup() in subsysmgr.c -- that causes tor to exit with an assertion failure on startup if the subsystems are not sorted by priority.

So we don't need to check the order in subsystem_list.c, because tor does it for us. That's good.

comment:4 Changed 12 days ago by nickm

Type: defectenhancement

Mark a number of current 0.4.2.x "defects" as "enhancements."

comment:5 Changed 9 days ago by teor

Parent ID: #31615
Note: See TracTickets for help on using tickets.