Update abicheck to require newer libstdc++.so.6

We should update projects/firefox/abicheck.cc to use features only provided by more recent versions of libstdc++.so.6.

Currently it only requires GLIBCXX_3.4.22:

$ strings tor-browser_en-US/Browser/abicheck | grep GLIBCXX_
GLIBCXX_3.4
GLIBCXX_3.4.22
GLIBCXX_3.4.21

https://gcc.gnu.org/onlinedocs/libstdc++/manual/abi.html

added TorBrowserTeam201909R actualpoints::3 component::applications/tor browser ff68-esr owner::tbb-team points::3 priority::very high resolution::fixed severity::normal status::closed tbb-9.0-must-alpha tbb-rbm type::defect labels

I wonder if #31380 (moved) is related here, although that one still puzzles me...

Replying to gk:

I wonder if #31380 (moved) is related here, although that one still puzzles me...

Ah yes, this is probably related.

On some systems, this can cause an error like this when starting the browser:

/usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.23' not found (required by $FOO/tor-browser_en-US_8.09a/Browser/libxul.so)

A temporary workaround is to edit the file Browser/firefox to move or copy the line add_LD_LIBRARY_PATH "$basedir/TorBrowser/Tor/libstdc++/" outside the if:

diff --git a/projects/firefox/start-firefox b/projects/firefox/start-firefox
index 7e7685c..42ea1af 100644
--- a/projects/firefox/start-firefox
+++ b/projects/firefox/start-firefox
@@ -41,6 +41,7 @@ fi
 if [ $? -ne 0 ]; then
   add_LD_LIBRARY_PATH "$basedir/TorBrowser/Tor/libstdc++/"
 fi
+add_LD_LIBRARY_PATH "$basedir/TorBrowser/Tor/libstdc++/"
 add_LD_LIBRARY_PATH "$basedir/TorBrowser/Tor/"
 export LD_LIBRARY_PATH
 

Trac:
Cc: N/A to intrigeri

There is a patch for review in branch bug_31646: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_31646&id=3ff1c896940d0150e90b12560c4a83f22263324c

With this patch, the abicheck binary now requires GLIBCXX_3.4.25, and the bundle is starting without error on a Debian 9 machine.

Trac:
Points: N/A to 3
Keywords: TorBrowserTeam201909 deleted, TorBrowserTeam201909R added
Status: new to needs_review

Two nits: * system provides required the C++ ABI not sure what you mean here.

Let's keep maint() instead of maint ().

Trac:
Keywords: TorBrowserTeam201909R deleted, TorBrowserTeam201909 added
Status: needs_review to needs_revision

This should be fixed in branch bug_31646_v2: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_31646_v2&id=c88f26cefc658be1773c459d9f63f728312fdf4e

Trac:
Keywords: TorBrowserTeam201909 deleted, TorBrowserTeam201909R added
Status: needs_revision to needs_review

Why does this DLL/DSO Hell happen regularly? On sane systems, the app's components always use the bundled version, and the system's components always use the system version. So, what the heck is here? And why these tickets are not synced to bumping GCC?

Replying to boklm:

This should be fixed in branch bug_31646_v2: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_31646_v2&id=c88f26cefc658be1773c459d9f63f728312fdf4e

Looks good. One additional nit: we should probably mention that this fix solves #31380 (moved), too?

Trac:
Status: needs_review to needs_revision
Keywords: TorBrowserTeam201909R deleted, TorBrowserTeam201909 added

Replying to cypherpunks:

Why does this DLL/DSO Hell happen regularly? On sane systems, the app's components always use the bundled version, and the system's components always use the system version. So, what the heck is here?

See #25485 (moved) for why we can't use the bundled libstdc++ in all cases.

And why these tickets are not synced to bumping GCC?

This should be done when bumping gcc, but was forgotten.

In branch bug_31646_v3 I updated the commit message to mention fixing #31380 (moved), and added a comment to projects/gcc/config to remind us about updating abicheck.cc when updating the gcc version: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_31646_v3&id=b16662aad8d9932819fea73746860ce9d8c711a4

Trac:
Status: needs_revision to needs_review
Keywords: TorBrowserTeam201909 deleted, TorBrowserTeam201909R added

That's not clear. AFAIK, symvers was developed, so that any package can update system version during installation and without bad consequences. But if you do something similar to Snap packages, isn't it easier to link statically?

Fixed with commit b16662aad8d9932819fea73746860ce9d8c711a4 on tor-browser-build's master branch, thanks.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Trac:
Actualpoints: N/A to 3

I noticed that on Debian 9, my 8.5.5 browser did not restart at the end of the update to 9.0. However it correctly started when starting it again manually.

On Debian 9, the bundled libstdc++.so.6 is not required in version 8.5.5, but is required in version 9.0, so I'm wondering if it could be related to this issue.

Replying to boklm:

I noticed that on Debian 9, my 8.5.5 browser did not restart at the end of the update to 9.0. However it correctly started when starting it again manually.

On Debian 9, the bundled libstdc++.so.6 is not required in version 8.5.5, but is required in version 9.0, so I'm wondering if it could be related to this issue.

I opened a separate ticket for this: #32212 (moved)

closed

changed time estimate to 24h

added 24h of time spent

mentioned in issue #31729 (moved)

mentioned in issue #32212 (moved)

moved to tpo/applications/tor-browser#31646 (closed)