Opened 2 months ago

Closed 3 weeks ago

#31658 closed defect (fixed)

The "Security Level" text is hard to read in dark mode

Reported by: Dbryrtfbcbhgf Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff68-esr, TorBrowserTeam201910R, tbb-security-slider, tbb-9.0-issues, tbb-9.0.1-can
Cc: pospeselr Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

When macOS has dark mode enabled and I click the shield icon, the words "Security Level" are very difficult to read. attached photo shows the issue.
TorBrowser 9.0a6

Child Tickets

Attachments (2)

Screen Shot 2019-09-05 at 11.16.04 PM.png (138.5 KB) - added by Dbryrtfbcbhgf 2 months ago.
windows.png (19.9 KB) - added by Thorin 2 months ago.
windows security-level-panel

Download all attachments as: .zip

Change History (13)

Changed 2 months ago by Dbryrtfbcbhgf

comment:1 Changed 2 months ago by gk

Is that a new issue with 9.0a6?

Changed 2 months ago by Thorin

Attachment: windows.png added

windows security-level-panel

comment:2 Changed 2 months ago by Thorin

TB based on ESR60, the security level panel is not themed (I just looked and tested). Here is windows (latest alpha) both default and dark themes. I wonder if prefers-color-scheme is playing a part: it is spoofed as light (just a thought, but probably not).

comment:3 Changed 2 months ago by gk

Cc: pospeselr added
Keywords: TorBrowserTeam201909 ff68-esr added

comment:4 Changed 2 months ago by gk

Points: 0.1

comment:5 Changed 6 weeks ago by pili

Keywords: TorBrowserTeam201910 added

comment:6 Changed 6 weeks ago by pili

Keywords: TorBrowserTeam201909 removed

comment:7 Changed 4 weeks ago by gk

Keywords: tbb-security-slider added

comment:8 Changed 3 weeks ago by gk

Keywords: tbb-9.0-issues tbb-9.0.1-can added

comment:9 Changed 3 weeks ago by pospeselr

Actual Points: 0.1
Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: newneeds_review

Switched the color to --panel-disabled-color to match the rest of 'disabled/dark' text in the Firefox UI.

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_31658

comment:10 Changed 3 weeks ago by pospeselr

Owner: changed from tbb-team to pospeselr
Status: needs_reviewassigned

comment:11 Changed 3 weeks ago by gk

Resolution: fixed
Status: assignedclosed

Looks good. Please provide the patch as fixup commit the next time (all the other security settings related "fixups" you did recently would have benefitted from that as well) to keep the amount of actual patches we need to carry around smaller.

Merged to tor-browser-68.2.0esr-9.5-1 (commit a9060232a8d72487c2e823513a2d73919d164ade) and tor-browser-68.2.0esr-9.0-1 (commit b2428d30e4b181b687c1509af5687097ef5b2166).

Note: See TracTickets for help on using tickets.