Opened 8 days ago

Last modified 35 hours ago

#31675 needs_review task

Split microdescs_parse_from_string() into smaller functions

Reported by: nickm Owned by: nickm
Priority: Low Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points: 0
Reviewer: asn Sponsor: Sponsor31-can

Description

Instead of making an extended practracker exception here, we should make this function conform to our best practices.

I'm taking this on because I need a quick finger exercise between larger things.

Child Tickets

Change History (5)

comment:1 Changed 8 days ago by nickm

Branch is ticket31675; PR at https://github.com/torproject/tor/pull/1309 . I'll put this in needs_review when CI passes.

For review, let's also think about the question: is this a good model for handling function-size practracker violations?

comment:2 Changed 8 days ago by nickm

CI passed, but I would like more test coverage.

comment:3 Changed 7 days ago by nickm

Status: assignedneeds_review

comment:4 Changed 7 days ago by nickm

(I've added tests, and gotten them passing)

comment:5 Changed 35 hours ago by asn

Reviewer: asn
Note: See TracTickets for help on using tickets.