Opened 6 weeks ago

Closed 5 weeks ago

#31679 closed defect (fixed)

Make checkShellScripts.sh handle path errors better

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: testing, 042-should, asn-merge
Cc: Actual Points: 0
Parent ID: Points: 0
Reviewer: nickm Sponsor:

Description

checkShellScripts.sh has two minor bugs:

  • it should handle being called from its parent directory on systems without realpath
  • it should exit with an error status if it can't find the src directory

This is a fix on master, so it doesn't need a changes file.

Child Tickets

Change History (5)

comment:1 Changed 6 weeks ago by teor

Status: assignedneeds_review

comment:2 Changed 5 weeks ago by nickm

Keywords: 042-should added

comment:3 Changed 5 weeks ago by asn

Reviewer: nickm

comment:4 Changed 5 weeks ago by nickm

Keywords: asn-merge added
Status: needs_reviewmerge_ready

LGTM.

comment:5 Changed 5 weeks ago by asn

Resolution: fixed
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.