Snowflake : ON/OFF switch

The ON/OFF switch is not user friendly, Maybe change the "Turn on" by "State : off" & "Turn off" by "State : on" ? Or just setup a static string with "State" ?

Thanks G.

added component::circumvention/snowflake priority::medium resolution::fixed reviewer::antonela severity::trivial snowflake-ux status::closed type::enhancement labels

Trac:

Trac:

Trac:
Cc: arlolra, cohosh, phw, dcf to arlolra, cohosh, phw, dcf, antonela
Keywords: N/A deleted, snowflake-ux added

The ON/OFF switch is not user friendly,

Can you expand on that?

When the switch is enabled, I expect to read "ON" and not "(turn) OFF". It can be confusing :/

Replying to cypherpunks:

When the switch is enabled, I expect to read "ON" and not "(turn) OFF". It can be confusing :/

Thanks for the input cypherpunks!

I'd like to get antonela's feedback on this. I'm worried that terminology like "State" makes more sense with a computer science background and can be confusing for users unfamiliar with coding or things like state machines.

I can see your point on how it could be more immediately clear to see simply "ON" or "OFF" with a toggle that changes it, but I don't have a background in UX. Are the other visual indicators (colour of snowflake, additional text above the toggle) useful?

Major design systems recommend avoiding using OFF/ON in the switcher since the UI component already reflects that status, especially for preventing this kind of confusion.

We can use a label that doesn't describe the values of a switch: what if we use Status or something close to it?

https://material.io/components/selection-controls/#switches https://developer.apple.com/design/human-interface-guidelines/ios/controls/switches/

"Status" is good but what about accessibility ?

Replying to antonela:

Major design systems recommend avoiding using OFF/ON in the switcher since the UI component already reflects that status, especially for preventing this kind of confusion.

We can use a label that doesn't describe the values of a switch: what if we use Status or something close to it?

https://material.io/components/selection-controls/#switches https://developer.apple.com/design/human-interface-guidelines/ios/controls/switches/

Status would be perfect

Trac:
Username: IPv7

Here's a patch that switches to using a static label, "Enabled"

https://github.com/keroserene/snowflake/commit/a9d7cb6f9384121c842ea68bf64731801be03564

I went with that because on chrome://extensions/ the toggles there have aria-label="Extension Enabled", but I found the "Extension" part redundant.

Trac:
Status: new to needs_review

Replying to arlolra:

Here's a patch that switches to using a static label, "Enabled"

https://github.com/keroserene/snowflake/commit/a9d7cb6f9384121c842ea68bf64731801be03564

I went with that because on chrome://extensions/ the toggles there have aria-label="Extension Enabled", but I found the "Extension" part redundant.

Perfect !

Trac:
Reviewer: N/A to cohosh

Looks good, and the code is good to merge. I'm going to ask antonela for the final say here since this is a user facing issue.

Trac:
Reviewer: cohosh to antonela

I thought we were moving forward with Status.

Anyways, I'm good merging arlolra's commit from comment:8. Thanks for this patch!

Merged as https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=36eb07a6fc1026b8b96471b72a17f578a2caff35

I thought we were moving forward with Status.

Sorry, I took a liberty here from when you said, "what if we use Status or something close to it?"

It's a 1-line change at this point. So, happy to make it if you prefer that.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/anti-censorship/pluggable-transports/snowflake#31685 (closed)