Opened 2 months ago

Closed 6 weeks ago

#31685 closed enhancement (fixed)

Snowflake : ON/OFF switch

Reported by: cypherpunks Owned by:
Priority: Medium Milestone:
Component: Circumvention/Snowflake Version:
Severity: Trivial Keywords: snowflake-ux
Cc: arlolra, cohosh, phw, dcf, antonela Actual Points:
Parent ID: Points:
Reviewer: antonela Sponsor:

Description

The ON/OFF switch is not user friendly,
Maybe change the "Turn on" by "State : off" & "Turn off" by "State : on" ?
Or just setup a static string with "State" ?

Thanks
G.

Child Tickets

Attachments (2)

off.png (1.8 KB) - added by cypherpunks 2 months ago.
on.png (9.1 KB) - added by cypherpunks 2 months ago.

Download all attachments as: .zip

Change History (16)

Changed 2 months ago by cypherpunks

Attachment: off.png added

Changed 2 months ago by cypherpunks

Attachment: on.png added

comment:1 Changed 2 months ago by cohosh

Cc: antonela added
Keywords: snowflake-ux added

comment:2 Changed 2 months ago by arlolra

The ON/OFF switch is not user friendly,

Can you expand on that?

comment:3 Changed 2 months ago by cypherpunks

When the switch is enabled, I expect to read "ON" and not "(turn) OFF".
It can be confusing :/

comment:4 in reply to:  3 Changed 2 months ago by cohosh

Replying to cypherpunks:

When the switch is enabled, I expect to read "ON" and not "(turn) OFF".
It can be confusing :/

Thanks for the input cypherpunks!

I'd like to get antonela's feedback on this. I'm worried that terminology like "State" makes more sense with a computer science background and can be confusing for users unfamiliar with coding or things like state machines.

I can see your point on how it could be more immediately clear to see simply "ON" or "OFF" with a toggle that changes it, but I don't have a background in UX. Are the other visual indicators (colour of snowflake, additional text above the toggle) useful?

comment:5 Changed 2 months ago by antonela

Major design systems recommend avoiding using OFF/ON in the switcher since the UI component already reflects that status, especially for preventing this kind of confusion.

We can use a label that doesn't describe the values of a switch: what if we use Status or something close to it?

https://material.io/components/selection-controls/#switches
https://developer.apple.com/design/human-interface-guidelines/ios/controls/switches/

comment:6 Changed 2 months ago by cypherpunks

"Status" is good but what about accessibility ?

comment:7 in reply to:  5 Changed 7 weeks ago by IPv7

Replying to antonela:

Major design systems recommend avoiding using OFF/ON in the switcher since the UI component already reflects that status, especially for preventing this kind of confusion.

We can use a label that doesn't describe the values of a switch: what if we use Status or something close to it?

https://material.io/components/selection-controls/#switches
https://developer.apple.com/design/human-interface-guidelines/ios/controls/switches/

Status would be perfect

comment:8 Changed 7 weeks ago by arlolra

Status: newneeds_review

Here's a patch that switches to using a static label, "Enabled"

https://github.com/keroserene/snowflake/commit/a9d7cb6f9384121c842ea68bf64731801be03564

I went with that because on chrome://extensions/ the toggles there have aria-label="Extension Enabled", but I found the "Extension" part redundant.

comment:9 in reply to:  8 Changed 7 weeks ago by cypherpunks

Replying to arlolra:

Here's a patch that switches to using a static label, "Enabled"

https://github.com/keroserene/snowflake/commit/a9d7cb6f9384121c842ea68bf64731801be03564

I went with that because on chrome://extensions/ the toggles there have aria-label="Extension Enabled", but I found the "Extension" part redundant.

Perfect ! 👍

comment:10 Changed 6 weeks ago by cohosh

Reviewer: cohosh

comment:11 Changed 6 weeks ago by cohosh

Reviewer: cohoshantonela

Looks good, and the code is good to merge. I'm going to ask antonela for the final say here since this is a user facing issue.

comment:12 Changed 6 weeks ago by antonela

I thought we were moving forward with Status.

Anyways, I'm good merging arlolra's commit from comment:8. Thanks for this patch!

comment:13 Changed 6 weeks ago by arlolra

Merged as https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=36eb07a6fc1026b8b96471b72a17f578a2caff35

I thought we were moving forward with Status.

Sorry, I took a liberty here from when you said, "what if we use Status or something close to it?"

It's a 1-line change at this point. So, happy to make it if you prefer that.

comment:14 Changed 6 weeks ago by arlolra

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.