Opened 4 months ago

Closed 4 months ago

Last modified 3 months ago

#31702 closed task (fixed)

Backport patch for bug 1578075 for macOS Catalina

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201909R
Cc: mcs, brade Actual Points: 0.1
Parent ID: Points: 0.25
Reviewer: Sponsor:

Description

We are almost ready to ship macOS bundles compatible with Catalina. However, we need to backport at least the patch for https://bugzilla.mozilla.org/show_bug.cgi?id=1578075 as Mozilla does not seem to be making another esr60 release.

Child Tickets

Change History (7)

comment:1 Changed 4 months ago by gk

Keywords: TorBrowserTeam201909R added; TorBrowserTeam201909 removed
Status: newneeds_review

comment:2 in reply to:  1 ; Changed 4 months ago by sysrqb

Status: needs_reviewmerge_ready

Replying to gk:

See my bug_31702 (https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_31702) for the backports.

These look good to me (although they could be squashed).

comment:3 in reply to:  2 Changed 4 months ago by gk

Keywords: tbb-backport added
Resolution: fixed
Status: merge_readyclosed

Replying to sysrqb:

Replying to gk:

See my bug_31702 (https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_31702) for the backports.

These look good to me (although they could be squashed).

Yeah, I decided against it as the commit series makes it more clear what exactly we are doing AND it well get replaced by the proper patch landing on esr68 anyway.

Merged to tor-browser-68.1.0esr-9.0-2 (commits 632458daf11b954319219ea62e259f50b4fd9ed3, e179405cb2f2e8fbbde1ce75b7d7dd9eadc2d4a0, and 7813cebd9f79de65d16e262ce79b675e7ec132c3).

Marking this for a possible backport in case we really think we should get an esr60-based build out with this bug fixed.

Last edited 4 months ago by gk (previous) (diff)

comment:4 Changed 4 months ago by sysrqb

Actual Points: 0.25

Adding points for my review, but it was only around 1 hour of work. Maybe together we spent ~2 hours on this.

comment:5 Changed 4 months ago by sysrqb

Actual Points: 0.25

Okay, no review points. GeKo can add actual points.

comment:6 Changed 4 months ago by gk

Actual Points: 0.1

comment:7 Changed 3 months ago by gk

Keywords: tbb-backport removed

No esr60-based builds anymore and thus no backport.

Note: See TracTickets for help on using tickets.