Backport patch for bug 1578075 for macOS Catalina

We are almost ready to ship macOS bundles compatible with Catalina. However, we need to backport at least the patch for https://bugzilla.mozilla.org/show_bug.cgi?id=1578075 as Mozilla does not seem to be making another esr60 release.

added TorBrowserTeam201909R actualpoints::0.1 component::applications/tor browser owner::tbb-team points::0.25 priority::very high resolution::fixed severity::normal status::closed type::task labels

See my bug_31702 (https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_31702) for the backports.

Trac:
Keywords: TorBrowserTeam201909 deleted, TorBrowserTeam201909R added
Status: new to needs_review

Replying to gk:

See my bug_31702 (https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_31702) for the backports. These look good to me (although they could be squashed).

Trac:
Status: needs_review to merge_ready

Replying to sysrqb:

Replying to gk:

See my bug_31702 (https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_31702) for the backports. These look good to me (although they could be squashed).

Yeah, I decided against it as the commit series makes it more clear what exactly we are doing AND it well get replaced by the proper patch landing on esr68 anyway.

Merged to tor-browser-68.1.0esr-9.0-2 (commits 632458daf11b954319219ea62e259f50b4fd9ed3, e179405cb2f2e8fbbde1ce75b7d7dd9eadc2d4a0, and 7813cebd9f79de65d16e262ce79b675e7ec132c3).

Marking this for a possible backport in case we really think we should get an esr60-based build out with this bug fixed.

Trac:
Keywords: N/A deleted, tbb-backport added
Status: merge_ready to closed
Resolution: N/A to fixed

Adding points for my review, but it was only around 1 hour of work. Maybe together we spent ~2 hours on this.

Trac:
Actualpoints: N/A to 0.25

Okay, no review points. GeKo can add actual points.

Trac:
Actualpoints: 0.25 to N/A

Trac:
Actualpoints: N/A to 0.1

No esr60-based builds anymore and thus no backport.

Trac:
Keywords: tbb-backport deleted, N/A added

closed

changed time estimate to 2h

added 48m of time spent

moved to tpo/applications/tor-browser#31702 (closed)