Opened 6 days ago

Last modified 35 hours ago

#31705 needs_review task

Add sufficient coccinelle tooling to run coccinelle without stress

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: teor Sponsor: Sponsor31-can

Description

I think we need two pieces of coccinelle tooling to be able to use it effectively:

1) A script that tells us which files have parsing problems.

2) A script to invoke spatch with the right arguments.

Based on 1 and 2, we can improve our tor-coccinelle.h file to handle more of our codebase, and we can apply coccinelle scripts without trying to remember the name of the "-macro-file-builtins" flag.

Child Tickets

Change History (3)

comment:1 Changed 6 days ago by nickm

See branch ticket31705 with PR at https://github.com/torproject/tor/pull/1321

comment:2 Changed 6 days ago by nickm

Status: assignedneeds_review

CI has passed

comment:3 Changed 35 hours ago by asn

Reviewer: teor
Note: See TracTickets for help on using tickets.