Opened 6 days ago

Last modified 5 days ago

#31713 new enhancement

Automatically rectify include paths before every commit

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #29226 Points:
Reviewer: Sponsor: Sponsor31-can

Description

Let's try out our auto-formatting workflow by running:
scripts/maint/rectify_include_paths.py .
before every commit.

We occasionally miss include paths:
https://github.com/torproject/tor/pull/1319/commits/a90d1918af5d2b6c6e6dd2c0797f8a63d4042bfa

We should only ever run auto-formatting on master.

Child Tickets

TicketTypeStatusOwnerSummary
#31759defectnewMake "annotate_ifdef_directives" script comply with line-width limits

Change History (2)

comment:1 Changed 5 days ago by nickm

Another possibility here is to run "make autostyle", which runs rectify_include_paths and several other autoformatters.

comment:2 Changed 5 days ago by teor

Yes, let's do that, and then we'll shake out a lot of the bugs in autostyling before the big restyle.

Note: See TracTickets for help on using tickets.