Opened 4 weeks ago

Closed 4 weeks ago

#31732 closed defect (fixed)

Windows nightly build failure

Reported by: boklm Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201909R, GeorgKoppen201909
Cc: Actual Points: 0.1
Parent ID: #30322 Points: 0.5
Reviewer: Sponsor:

Description

The Windows nightly builds currently fail while building firefox with:

31:36.72 /var/tmp/dist/mingw-w64-clang/bin/x86_64-w64-mingw32-clang++ -mwindows -shared -Wl,--out-implib -Wl,libclearkey.a -Wl,-pdb,clearkey.pdb -o clearkey.dll @/var/tmp/build/firefox-e489c5048b76/obj-mingw/media/gmp-clearkey/0.1/clearkey_dll.list ./module.res  -Wl,--no-insert-timestamp -Wl,--dynamicbase -Wl,--icf=safe        -luuid -lusp10 -lgdi32 -lwinmm -lwsock32 -luserenv -lsecur32 -lmfuuid
31:36.77 lld-link: error: undefined symbol: __strcat_chk
31:36.77 >>> referenced by /var/tmp/build/firefox-e489c5048b76/media/gmp-clearkey/0.1/openaes/oaes_lib.c:459
31:36.77 >>>               oaes_lib.o:(oaes_sprintf)
31:36.77 clang-8: error: linker command failed with exit code 1 (use -v to see invocation)
31:36.77 /var/tmp/build/firefox-e489c5048b76/config/rules.mk:680: recipe for target 'clearkey.dll' failed
31:36.77 make[4]: *** [clearkey.dll] Error 1

Child Tickets

Change History (4)

comment:1 Changed 4 weeks ago by gk

Keywords: GeorgKoppen201909 added
Parent ID: #30322
Points: 0.5

Okay, that's weird. I gonna look into it. This seems to be happening for both 32-bit and 64-bit builds.

Last edited 4 weeks ago by gk (previous) (diff)

comment:2 Changed 4 weeks ago by gk

I guess that's https://bugzilla.mozilla.org/show_bug.cgi?id=1577872#c14. I think we should switch to what Mozilla is using. I prepare a patch and test it shortly.

comment:3 Changed 4 weeks ago by gk

Actual Points: 0.1
Keywords: TorBrowserTeam201909R added; TorBrowserTeam201909 removed
Status: newneeds_review

bug_31732 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_31732&id=554d1014079a9d83586759ee92280c8b094e682a) in my tor-browser-build repo has a fix for this bug. We follow Mozilla in the commit we use which seems to be smarter. :)

comment:4 in reply to:  3 Changed 4 weeks ago by boklm

Resolution: fixed
Status: needs_reviewclosed

Replying to gk:

bug_31732 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_31732&id=554d1014079a9d83586759ee92280c8b094e682a) in my tor-browser-build repo has a fix for this bug. We follow Mozilla in the commit we use which seems to be smarter. :)

This looks good to me. I merged it to master as commit 554d1014079a9d83586759ee92280c8b094e682a.

Note: See TracTickets for help on using tickets.