Opened 4 weeks ago

Closed 6 days ago

#31747 closed defect (fixed)

Some browser UI is always shown in English

Reported by: acat Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff68-esr tbb-9.0-must-alpha TorBrowserTeam201910R, GeorgKoppen201910R
Cc: acat Actual Points: 1
Parent ID: Points:
Reviewer: Sponsor:

Description

Some browser UI is always shown in English, tested with es-ES and fr. Not an exhaustive list:

  • Most of about:preferences.
  • Tor Browser is up to date and Checking for updates... in About Tor Browser.
  • Some internal pages like about:support.

Child Tickets

Change History (21)

comment:1 Changed 4 weeks ago by gk

I guess the first item is essentially #28196?

comment:2 Changed 4 weeks ago by gk

(Oh, and I think the the text on the onboarding bubble in the upper left corner is a another case for this bug)

comment:3 Changed 4 weeks ago by acat

I guess the first item is essentially #28196?

Yes, and probably the second and third too.

(Oh, and I think the the text on the onboarding bubble in the upper left corner is a another case for this bug)

This is due to onboarding.properties not being present in the language packs anymore (since we resurrected the old onboarding). I'm not sure how to solve this one, perhaps extracting the strings for the locales we support from the old Firefox onboarding.properties and moving them to torbutton? (I guess at some point we'll rename torbutton :))

comment:4 in reply to:  3 Changed 3 weeks ago by gk

Replying to acat:

I guess the first item is essentially #28196?

Yes, and probably the second and third too.

(Oh, and I think the the text on the onboarding bubble in the upper left corner is a another case for this bug)

This is due to onboarding.properties not being present in the language packs anymore (since we resurrected the old onboarding). I'm not sure how to solve this one, perhaps extracting the strings for the locales we support from the old Firefox onboarding.properties and moving them to torbutton? (I guess at some point we'll rename torbutton :))

Sounds good to me.

comment:5 Changed 2 weeks ago by acat

Keywords: TorBrowserTeam201910R added
Status: newneeds_review

Using this ticket just for the onboarding issue, since the other ones should be solved in #28196.

Patches for review in https://www.github.com/acatarineu/torbutton/commit/31747 and https://www.github.com/acatarineu/tor-browser/commit/31747

comment:6 Changed 13 days ago by gk

Keywords: TorBrowserTeam201910 added; TorBrowserTeam201910R removed
Status: needs_reviewneeds_revision

Looks mostly good. Could you make the tor-browser patch to fixup patch to an onboarding commit before (maybe the one for #28882 but I don't feel strongly about that)?

comment:7 Changed 13 days ago by acat

Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: needs_revisionneeds_review

comment:8 Changed 13 days ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. I applied your patch to torbutton's master (commit a07b24bdc1c7a5a7836c6d3f864fcdff03bbdb15) and tor-browser's tor-browser-68.1.0esr-9.0-2 (commit 62c667c57e9e00fee0b0849e61e44e9999c14f39).

comment:9 Changed 12 days ago by gk

Cc: acat added
Keywords: TorBrowserTeam201910 GeorgKoppen201910 added; TorBrowserTeam201910R removed
Resolution: fixed
Status: closedreopened

That busted mk where the strings are missing. I am looking at a fix now.

comment:10 Changed 12 days ago by gk

Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: reopenedneeds_review

bug_31747 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_31747&id=38712377b6833ae19951ac236e8da83570f3d898) has a fix for review. As to what went wrong the theory I have is:

08:56 <+GeKo> i don't think so. i think what happens is that the code 
              generating the lang pack is seeing untranslated strings in the hg 
              repo and putting the english placeholders in it
08:56 <+GeKo> but you pulling them did not get those

comment:11 Changed 9 days ago by acat

As discussed on IRC, I'm using this to make onboarding.properties include only properties currently required. If I'm not wrong these are onboarding.overlay-icon-tooltip2, onboarding.overlay-icon-tooltip-updated2 and onboarding.complete. I used English as fallback where some of these three strings was not available (that should fix the mk issue).

https://github.com/acatarineu/torbutton/commit/31747+1.

comment:12 Changed 9 days ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. I am not sure yet about onboarding.complete. I tried playing with my onboarding a bit and could never made it to show up. However, I probably tried not hard enough. I am fine leaving it in for that case.

Cherry-picked to master (commit 2aefbbe0aba0b9808f87e9c8ddf2146341fa13a7)

comment:13 Changed 8 days ago by acat

Keywords: GeorgKoppen201910R added; GeorgKoppen201910 removed
Resolution: fixed
Status: closedreopened

Unfortunately, I missed a couple of strings and this breaks the onboarding, must have done something wrong when testing. Fixup in https://github.com/acatarineu/torbutton/commit/31747+2.

comment:14 Changed 8 days ago by acat

Status: reopenedneeds_review

comment:15 Changed 8 days ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks still good. :) Merged to master (commit 4f453d5570d4177f82f2215d8041f901a13a92a1).

comment:16 Changed 7 days ago by acat

Points: 1

comment:17 Changed 7 days ago by acat

Actual Points: 1
Points: 1

comment:18 Changed 6 days ago by Zarko_Gjurov

Which app we the translators need to use to translate/edit this "onboarding.properties" file? Because when it is opened and edited via Firefox Dev Tools (Inspector) can not be saved, via Notepad can be saved but the format and loading in Firefox is like textual file and not the like original format of non-edited one. The same happens with editing and saving via Microsoft XML Notepad 2007 and IDM UltraEdit 21 the HEX editor. So what app or online service we need to use to translate the file?

comment:19 Changed 6 days ago by acat

Resolution: fixed
Status: closedreopened

comment:20 Changed 6 days ago by acat

Status: reopenedneeds_review

comment:21 Changed 6 days ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Cherry-picked to master (commit 1fb06b910d8e896084d3c515e26cf11b1b95b858).

Note: See TracTickets for help on using tickets.