Some browser UI is always shown in English

Some browser UI is always shown in English, tested with es-ES and fr. Not an exhaustive list:

• Most of about:preferences.
• Tor Browser is up to date and Checking for updates... in About Tor Browser.
• Some internal pages like about:support.

added GeorgKoppen201910R TorBrowserTeam201910R actualpoints::1 component::applications/tor browser ff68-esr owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-9.0-must-alpha type::defect labels

I guess the first item is essentially #28196 (moved)?

(Oh, and I think the the text on the onboarding bubble in the upper left corner is a another case for this bug)

I guess the first item is essentially #28196 (moved)? Yes, and probably the second and third too.

(Oh, and I think the the text on the onboarding bubble in the upper left corner is a another case for this bug) This is due to onboarding.properties not being present in the language packs anymore (since we resurrected the old onboarding). I'm not sure how to solve this one, perhaps extracting the strings for the locales we support from the old Firefox onboarding.properties and moving them to torbutton? (I guess at some point we'll rename torbutton :))

Replying to acat:

I guess the first item is essentially #28196 (moved)? Yes, and probably the second and third too.

(Oh, and I think the the text on the onboarding bubble in the upper left corner is a another case for this bug) This is due to onboarding.properties not being present in the language packs anymore (since we resurrected the old onboarding). I'm not sure how to solve this one, perhaps extracting the strings for the locales we support from the old Firefox onboarding.properties and moving them to torbutton? (I guess at some point we'll rename torbutton :))

Sounds good to me.

Using this ticket just for the onboarding issue, since the other ones should be solved in #28196 (moved).

Patches for review in https://www.github.com/acatarineu/torbutton/commit/31747 and https://www.github.com/acatarineu/tor-browser/commit/31747

Trac:
Keywords: ff68-esr tbb-9.0-must-alpha deleted, ff68-esr tbb-9.0-must-alpha TorBrowserTeam201910R added
Status: new to needs_review

Looks mostly good. Could you make the tor-browser patch to fixup patch to an onboarding commit before (maybe the one for #28882 (moved) but I don't feel strongly about that)?

Trac:
Status: needs_review to needs_revision
Keywords: ff68-esr tbb-9.0-must-alpha TorBrowserTeam201910R deleted, ff68-esr tbb-9.0-must-alpha TorBrowserTeam201910 added

Done: https://github.com/acatarineu/tor-browser/commit/31747+1

Trac:
Status: needs_revision to needs_review
Keywords: ff68-esr tbb-9.0-must-alpha TorBrowserTeam201910 deleted, ff68-esr tbb-9.0-must-alpha TorBrowserTeam201910R added

Looks good. I applied your patch to torbutton's master (commit a07b24bdc1c7a5a7836c6d3f864fcdff03bbdb15) and tor-browser's tor-browser-68.1.0esr-9.0-2 (commit 62c667c57e9e00fee0b0849e61e44e9999c14f39).

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

That busted mk where the strings are missing. I am looking at a fix now.

Trac:
Status: closed to reopened
Cc: N/A to acat
Resolution: fixed to N/A
Keywords: ff68-esr tbb-9.0-must-alpha TorBrowserTeam201910R deleted, ff68-esr tbb-9.0-must-alpha TorBrowserTeam201910, GeorgKoppen201910 added

bug_31747 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_31747&id=38712377b6833ae19951ac236e8da83570f3d898) has a fix for review. As to what went wrong the theory I have is:

08:56 <+GeKo> i don't think so. i think what happens is that the code 
              generating the lang pack is seeing untranslated strings in the hg 
              repo and putting the english placeholders in it
08:56 <+GeKo> but you pulling them did not get those

Trac:
Keywords: ff68-esr tbb-9.0-must-alpha TorBrowserTeam201910 deleted, ff68-esr tbb-9.0-must-alpha TorBrowserTeam201910R added
Status: reopened to needs_review

As discussed on IRC, I'm using this to make onboarding.properties include only properties currently required. If I'm not wrong these are onboarding.overlay-icon-tooltip2, onboarding.overlay-icon-tooltip-updated2 and onboarding.complete. I used English as fallback where some of these three strings was not available (that should fix the mk issue).

https://github.com/acatarineu/torbutton/commit/31747+1.

Thanks. I am not sure yet about onboarding.complete. I tried playing with my onboarding a bit and could never made it to show up. However, I probably tried not hard enough. I am fine leaving it in for that case.

Cherry-picked to master (commit 2aefbbe0aba0b9808f87e9c8ddf2146341fa13a7)

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Unfortunately, I missed a couple of strings and this breaks the onboarding, must have done something wrong when testing. Fixup in https://github.com/acatarineu/torbutton/commit/31747+2.

Trac:
Status: closed to reopened
Resolution: fixed to N/A
Keywords: GeorgKoppen201910 deleted, GeorgKoppen201910R added

Trac:
Status: reopened to needs_review

Looks still good. :) Merged to master (commit 4f453d5570d4177f82f2215d8041f901a13a92a1).

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

Trac:
Points: N/A to 1

Trac:
Actualpoints: N/A to 1
Points: 1 to N/A

Which app we the translators need to use to translate/edit this "onboarding.properties" file? Because when it is opened and edited via Firefox Dev Tools (Inspector) can not be saved, via Notepad can be saved but the format and loading in Firefox is like textual file and not the like original format of non-edited one. The same happens with editing and saving via Microsoft XML Notepad 2007 and IDM UltraEdit 21 the HEX editor. So what app or online service we need to use to translate the file?

Trac:
Username: Zarko_Gjurov

One more fixup for mk locale: https://github.com/acatarineu/torbutton/commit/31747+3. Strings from https://share.riseup.net/#k1gL4rYC9_ksqY35EyOvzA.

Trac:
Resolution: fixed to N/A
Status: closed to reopened

Trac:
Status: reopened to needs_review

Looks good. Cherry-picked to master (commit 1fb06b910d8e896084d3c515e26cf11b1b95b858).

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

added 8h of time spent

moved to tpo/applications/tor-browser#31747 (closed)