Opened 4 weeks ago

Last modified 4 hours ago

#31748 needs_review defect

"Learn More" link in Security Level popup is not working

Reported by: acat Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff68-esr, TorBrowserTeam201910R
Cc: tbb-team Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description


Child Tickets

Change History (6)

comment:1 Changed 4 weeks ago by pospeselr

(09/19/2019 09:41:48 AM) pospeselr: hey acat, just stumbled on a fix for #31748
(09/19/2019 09:41:49 AM) zwiebelbot: (notice) tor#31748: "Learn More" link in Security Level popup is not working - [new] - https://bugs.torproject.org/31748
(09/19/2019 09:42:12 AM) pospeselr: we need to add an is="text-link" attribute to "Learn More" label elements to get them to work as links again
(09/19/2019 09:44:18 AM) pospeselr: will need to add to the Learn More links in both securityLevelPreferences.inc.xul and securityLevelPanel.inc.xul

comment:2 Changed 2 days ago by pospeselr

Cc: tbb-team added
Owner: changed from tbb-team to pospeselr
Status: newassigned

comment:3 Changed 2 days ago by pospeselr

Cc: TorBrowserTeam201910 added

comment:4 Changed 18 hours ago by gk

Cc: TorBrowserTeam201910 removed
Keywords: TorBrowserTeam201910 added

comment:5 Changed 4 hours ago by pospeselr

Actual Points: 0.1
Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Points: 0.25
Status: assignedneeds_review

Solution was as simple as described above, just needed to update the label elements with the is="text-link" attribute.

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_31748_review

comment:6 Changed 4 hours ago by pospeselr

Points: 0.250.1
Note: See TracTickets for help on using tickets.