Opened 2 months ago

Closed 4 weeks ago

#31748 closed defect (fixed)

"Learn More" link in Security Level popup is not working

Reported by: acat Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff68-esr, TorBrowserTeam201910R
Cc: tbb-team Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description


Child Tickets

Change History (7)

comment:1 Changed 8 weeks ago by pospeselr

(09/19/2019 09:41:48 AM) pospeselr: hey acat, just stumbled on a fix for #31748
(09/19/2019 09:41:49 AM) zwiebelbot: (notice) tor#31748: "Learn More" link in Security Level popup is not working - [new] - https://bugs.torproject.org/31748
(09/19/2019 09:42:12 AM) pospeselr: we need to add an is="text-link" attribute to "Learn More" label elements to get them to work as links again
(09/19/2019 09:44:18 AM) pospeselr: will need to add to the Learn More links in both securityLevelPreferences.inc.xul and securityLevelPanel.inc.xul

comment:2 Changed 4 weeks ago by pospeselr

Cc: tbb-team added
Owner: changed from tbb-team to pospeselr
Status: newassigned

comment:3 Changed 4 weeks ago by pospeselr

Cc: TorBrowserTeam201910 added

comment:4 Changed 4 weeks ago by gk

Cc: TorBrowserTeam201910 removed
Keywords: TorBrowserTeam201910 added

comment:5 Changed 4 weeks ago by pospeselr

Actual Points: 0.1
Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Points: 0.25
Status: assignedneeds_review

Solution was as simple as described above, just needed to update the label elements with the is="text-link" attribute.

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_31748_review

comment:6 Changed 4 weeks ago by pospeselr

Points: 0.250.1

comment:7 Changed 4 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. That's actually caused by us not picking this change up while rebasing, right? So, we should do this kind of fixups as fixups to the commit they belong to. I'll take the commit as-is now (commit 1a8a46866f0dfd69c7a477ce8e3a46c9640e3a53 on tor-browser-68.1.0esr-9.0-3) to make the release process not more complicated as it already is. I think, though, we could squash a bunch of commits that are fixing up issues found with the main securitySettings related patch into one single commit (I noted that on #31918).

Note: See TracTickets for help on using tickets.