"Learn More" link in Security Level popup is not working

added TorBrowserTeam201910R actualpoints::0.1 component::applications/tor browser ff68-esr owner::pospeselr points::0.1 priority::medium resolution::fixed severity::normal status::closed type::defect labels

(09/19/2019 09:41:48 AM) pospeselr: hey acat, just stumbled on a fix for #31748
(09/19/2019 09:41:49 AM) zwiebelbot: (notice) tor#31748: "Learn More" link in Security Level popup is not working - [new] - https://bugs.torproject.org/31748
(09/19/2019 09:42:12 AM) pospeselr: we need to add an is="text-link" attribute to "Learn More" label elements to get them to work as links again
(09/19/2019 09:44:18 AM) pospeselr: will need to add to the Learn More links in both securityLevelPreferences.inc.xul and securityLevelPanel.inc.xul

Trac:
Owner: tbb-team to pospeselr
Cc: N/A to tbb-team
Status: new to assigned

Trac:
Cc: tbb-team to tbb-team, TorBrowserTeam201910

Trac:
Cc: tbb-team, TorBrowserTeam201910 to tbb-team
Keywords: N/A deleted, TorBrowserTeam201910 added

Solution was as simple as described above, just needed to update the label elements with the is="text-link" attribute.

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_31748_review

Trac:
Keywords: TorBrowserTeam201910 deleted, TorBrowserTeam201910R added
Points: N/A to 0.25
Status: assigned to needs_review
Actualpoints: N/A to 0.1

Trac:
Points: 0.25 to 0.1

Looks good. That's actually caused by us not picking this change up while rebasing, right? So, we should do this kind of fixups as fixups to the commit they belong to. I'll take the commit as-is now (commit 1a8a46866f0dfd69c7a477ce8e3a46c9640e3a53 on tor-browser-68.1.0esr-9.0-3) to make the release process not more complicated as it already is. I think, though, we could squash a bunch of commits that are fixing up issues found with the main securitySettings related patch into one single commit (I noted that on #31918 (moved)).

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

changed time estimate to 48m

added 48m of time spent

mentioned in issue #31961 (moved)

moved to tpo/applications/tor-browser#31748 (closed)