Opened 2 months ago

Closed 4 weeks ago

#31749 closed defect (fixed)

Security level popup should not open with middle or right click

Reported by: acat Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-security-slider, tbb-9.0, TorBrowserTeam201910R
Cc: tbb-team Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

This is probably because of the change

-               oncommand="SecurityLevelButton.onCommand(this, event);"
+               onmousedown="SecurityLevelButton.onCommand();"

Child Tickets

Change History (7)

comment:1 Changed 2 months ago by acat

Keywords: tbb-security-slider added

comment:2 Changed 6 weeks ago by pospeselr

Owner: changed from tbb-team to pospeselr
Status: newassigned

comment:3 Changed 6 weeks ago by pospeselr

Cc: tbb-team added

comment:4 Changed 6 weeks ago by pospeselr

Keywords: tbb-9.0 TorBrowserTeam201910 added
Points: 0.25

comment:5 Changed 4 weeks ago by pospeselr

Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: assignedneeds_review

Fixed this behavior, now we correctly mirror the behavior of Downloads et al with respect to input events.

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_31749_review

comment:6 Changed 4 weeks ago by pospeselr

Actual Points: 0.1
Points: 0.250.1

comment:7 Changed 4 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Cherry-picked to tor-browser-68.1.0esr-9.0-3 (commit 071eea2a3b95c686b4a044481a975131a3261a34). I put a small fixup on top of it to remove some typos (commit f17113f06b92a16e01973b1f05b795ed321ffc7f).

Note: See TracTickets for help on using tickets.