Opened 4 weeks ago

Closed 2 weeks ago

#31779 closed defect (fixed)

annotate_ifdef_directives: avoid double-negation

Reported by: nickm Owned by: nickm
Priority: Low Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: 042-should
Cc: Actual Points:
Parent ID: #31759 Points:
Reviewer: catalyst Sponsor:

Description

As a minor tweak, we should try to stop emitting things like:

#else /* !(!defined(HAVE_SYS_UN_H)) */

Child Tickets

Change History (4)

comment:1 Changed 4 weeks ago by nickm

Status: assignedneeds_review

In needs_review because parent is in needs_review. Included in parent's branch.

comment:2 Changed 3 weeks ago by asn

Reviewer: catalyst

comment:3 Changed 3 weeks ago by catalyst

Status: needs_reviewneeds_revision

Both are implemented by the same branch, which could use some minor revisions

comment:4 Changed 2 weeks ago by teor

Resolution: fixed
Status: needs_revisionclosed

Merged in #31759.

Note: See TracTickets for help on using tickets.