Opened 2 months ago

Last modified 8 weeks ago

#31812 needs_revision defect

http URL's in docs/comments should be https

Reported by: JeremyRand Owned by:
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 042-can docs
Cc: Actual Points:
Parent ID: Points:
Reviewer: catalyst Sponsor:

Description

The documentation and comments in Tor's repo have quite a few http URL's that should be changed to https. Patch incoming shortly for this.

Child Tickets

Change History (6)

comment:1 Changed 2 months ago by JeremyRand

Patch at https://notabug.org/JeremyRand/tor/src/https-urls (Git commit hash 90feaa278b6b58ea67a1ab4e5fb7ea417741dc75).

comment:2 Changed 2 months ago by nickm

Keywords: 042-can docs added
Milestone: Tor: 0.4.2.x-final
Status: newneeds_review

comment:3 Changed 2 months ago by asn

Reviewer: catalyst

comment:4 in reply to:  1 Changed 2 months ago by catalyst

Status: needs_reviewneeds_information

Replying to JeremyRand:

Patch at https://notabug.org/JeremyRand/tor/src/https-urls (Git commit hash 90feaa278b6b58ea67a1ab4e5fb7ea417741dc75).

Thanks for the patch! It mostly looks good. I have a few minor comments.

Did you verify that each HTTPS URL that you produced actually works?

Also, I would prefer to leave "upstream" text unchanged. This includes the comments in Doxyfile.in (which is auto-generated boilerplate from Doxygen) and license text in LICENSE. (Some licenses arguably require verbatim reproduction of the license text, and it's unclear to me whether changing http:// to https:// would be allowed. We could check whether the upstream projects have updated the URLs in their license text, I guess.)

What do you think?

comment:5 Changed 2 months ago by nickm

I agree that we shouldn't edit other people's licenses, anything generated by doxygen or any other tool, and anything in src/ext that we didn't write.

comment:6 Changed 8 weeks ago by catalyst

Status: needs_informationneeds_revision
Note: See TracTickets for help on using tickets.