http URL's in docs/comments should be https

The documentation and comments in Tor's repo have quite a few http URL's that should be changed to https. Patch incoming shortly for this.

changed milestone to %Tor: 0.4.4.x-final

added 042-can component::core tor/tor docs milestone::Tor: 0.4.4.x-final priority::medium reviewer::catalyst severity::normal status::needs-revision type::defect labels

Patch at https://notabug.org/JeremyRand/tor/src/https-urls (Git commit hash 90feaa278b6b58ea67a1ab4e5fb7ea417741dc75).

Trac:
Milestone: N/A to Tor: 0.4.2.x-final
Status: new to needs_review
Keywords: N/A deleted, 042-can docs added

Trac:
Reviewer: N/A to catalyst

Replying to JeremyRand:

Patch at https://notabug.org/JeremyRand/tor/src/https-urls (Git commit hash 90feaa278b6b58ea67a1ab4e5fb7ea417741dc75). Thanks for the patch! It mostly looks good. I have a few minor comments.

Did you verify that each HTTPS URL that you produced actually works?

Also, I would prefer to leave "upstream" text unchanged. This includes the comments in Doxyfile.in (which is auto-generated boilerplate from Doxygen) and license text in LICENSE. (Some licenses arguably require verbatim reproduction of the license text, and it's unclear to me whether changing http:// to https:// would be allowed. We could check whether the upstream projects have updated the URLs in their license text, I guess.)

What do you think?

Trac:
Status: needs_review to needs_information

I agree that we shouldn't edit other people's licenses, anything generated by doxygen or any other tool, and anything in src/ext that we didn't write.

Trac:
Status: needs_information to needs_revision

Trac:
Milestone: Tor: 0.4.2.x-final to Tor: 0.4.4.x-final

moved to tpo/core/tor#31812 (closed)