Opened 3 weeks ago

Last modified 4 days ago

#31823 needs_review defect

HSv3 descriptor support in stem [encoding]

Reported by: asn Owned by: atagar
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Stem Version:
Severity: Normal Keywords: tor-hs scaling onionbalance network-team-roadmap-september tor-spec
Cc: s7r, gk, atagar Actual Points: 2
Parent ID: #26768 Points: 5
Reviewer: Sponsor:

Description

This is a ticket for impementing HSv3 descriptor encoding in stem.

Some more details here: https://trac.torproject.org/projects/tor/ticket/31369#comment:12

Child Tickets

Change History (1)

comment:1 Changed 4 days ago by asn

Cc: atagar added
Status: newneeds_review

OK I present a draft version of this functionality at: https://github.com/torproject/stem/pull/24

It's a big branch with over 1k lines of code. It's not yet ready for production, but I posted it here to get some feedback from you atagar on what needs to be changed and improved. Also the interface of HiddenServiceV3Descriptor has changed (since we require more data to be able to minimally encode them) and this broke some of the simpler tests in the test suite. I can fix those too.

The branch basically builds up from small things (key blinding), to encoding descriptors and finally to being able to do a full on encode-to-decode unittest using the branch from #31369. The format of this unittest is the same logic I'm planning to use in onionbalance when encoding v3 descriptors. Also, I passed a stem descriptor to little-t-tor and verified that little-t-tor parses it well.

Starting tomorrow I will be offline for two weeks, so feel free to take your time reading this code. When I get back I will have more time to revise this branch and do any changes you might like.

Enjoy and thanks for the feedback!

Last edited 4 days ago by asn (previous) (diff)
Note: See TracTickets for help on using tickets.