Make test_rebind.py more robust

• actually sleep when waiting for tor to log
• log at debug level when waiting for tor to log
• backslash-replace bad UTF-8 characters in logs
• format control commands as ASCII, tor does not accept UTF-8 control commands

Found during #30901 (moved).

changed milestone to %Tor: 0.3.5.x-final

added 035-backport 040-backport 041-backport 042-can BugSmashFund actualpoints::0.1 asn-merge component::core tor/tor consider-backport-after-0423 milestone::Tor: 0.3.5.x-final owner::teor points::0.1 priority::medium resolution::fixed reviewer::dgoulet severity::normal status::closed type::defect labels

See my pull request:

• 0.3.5: https://github.com/torproject/tor/pull/1354

The merge forward is all clean.

Trac:
Status: assigned to needs_review
Keywords: N/A deleted, consider-backport-after-0423 added

Trac:
Keywords: BugSmashFund deleted, BugSmashFund 042-can added

Trac:
Reviewer: N/A to dgoulet

lgtm

Trac:
Keywords: N/A deleted, asn-merge added
Status: needs_review to merge_ready

This line looks wrong:

+            logging.debug('Tor has not logged anything, waiting for "{}"'.format(l.strip(), s))

You're calling format with two arguments, but the format string only has one {} entry.

Trac:
Status: merge_ready to needs_revision

You're right, l is the empty string here, so it does not need to be printed,

Replying to teor:

See my pull request:

• 0.3.5: https://github.com/torproject/tor/pull/1354

The merge forward is all clean.

I deleted l.strip(), , amended the commit, and force-pushed.

Anyone can merge this branch to master after CI passes.

Since it's a CI stability fix, it should get some testing in master, so I will backport after 0.4.2.3.

Trac:
Status: needs_revision to merge_ready

Merged to 0.4.2 and later: obviously correct fixes to already reviewed code.

Trac:
Milestone: Tor: 0.4.2.x-final to Tor: 0.4.1.x-final

Merged to 0.3.5 and later. Merged #31107 (moved), #31466 (moved), #30916 (moved), #31408 (moved), #31837 (moved), and #31897 (moved) together.

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed
Milestone: Tor: 0.4.1.x-final to Tor: 0.3.5.x-final

closed

changed time estimate to 48m

added 48m of time spent

mentioned in issue #31897 (moved)

moved to tpo/core/tor#31837 (closed)