Opened 3 weeks ago

Closed 13 days ago

#31840 closed enhancement (implemented)

Refactor some control error-handling code

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt 042-can
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: catalyst Sponsor: Sponsor31-can

Description (last modified by teor)

This change reduces the size of a practracker exception

Child Tickets

Change History (6)

comment:1 Changed 3 weeks ago by teor

Description: modified (diff)
Status: assignedneeds_review

comment:2 Changed 3 weeks ago by nickm

Keywords: 042-can added; BugSmashFund removed
Sponsor: Sponsor31-can

Adding 042-can; removing bugsquashfund; adding sponsor31-can. (My understanding is that the bugsquashfund keyword should be reserved for user-visible bugs.)

comment:3 Changed 2 weeks ago by teor

Reviewer: catalyst

comment:4 in reply to:  1 Changed 2 weeks ago by catalyst

Status: needs_reviewneeds_revision

Replying to teor:

See my PR:

Thanks! This code (and the existing version) looks uncovered, which makes me slightly nervous. The changes also look to be almost pure code movement so that might be safe.

I left some minor comments on the pull request, mostly about naming. Feel free to address them if you like, and set to merge_ready once CI passes on any changes.

comment:5 Changed 2 weeks ago by teor

Status: needs_revisionmerge_ready

Done in a force-pushed commit.

Please merge:

comment:6 Changed 13 days ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged to master.

Note: See TracTickets for help on using tickets.