Opened 11 months ago

Closed 9 months ago

#31853 closed task (implemented)

Move into our coding standards document

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: network-team-roadmap-november, s31-docs
Cc: nickm, catalyst Actual Points: .1
Parent ID: #29214 Points:
Reviewer: nickm Sponsor: Sponsor31-can


There seems to be some overlap between our coding standards and the advice in

We should merge that advice into the coding standards.

Child Tickets

Change History (5)

comment:1 Changed 11 months ago by rl1987

Status: newneeds_review

comment:2 Changed 10 months ago by teor

Reviewer: nickm

comment:3 Changed 10 months ago by nickm

Status: needs_reviewneeds_revision

This looks good to me, but there are still parts of that do not seem to have made it over, like the one about reallocarray and the one about aton and pton. There may be more. We should make sure we aren't losing any information in this document combination.

Also, as part of this work, we should remove doc/HACKING/

comment:4 Changed 9 months ago by catalyst

Cc: catalyst added

comment:5 Changed 9 months ago by nickm

Actual Points: .1
Resolution: implemented
Sponsor: Sponsor31-can
Status: needs_revisionclosed

I've merged your patch, then gone through and merged the remaining items from Thanks!

Note: See TracTickets for help on using tickets.