Opened 11 months ago

Closed 7 months ago

Last modified 7 months ago

#31855 closed task (fixed)

Remove End of Year Fundraising Campaign from about:tor

Reported by: pili Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201912R, tbb-backported
Cc: tbb-team Actual Points:
Parent ID: Points: 0.5
Reviewer: Sponsor:

Description

At the start of 2020, we should remove the EOY Fundraising elements from Tor Browser

Child Tickets

Change History (12)

comment:1 Changed 8 months ago by pili

Summary: Remove End of Year Fundraising Campaign BannerRemove End of Year Fundraising Campaign from about:tor

comment:2 Changed 8 months ago by pili

Keywords: TorBrowserTeam201912 added; TorBrowserTeam202001 removed

comment:3 Changed 8 months ago by pili

Owner: changed from tbb-team to mcs
Status: newassigned

comment:4 Changed 8 months ago by brade

Cc: tbb-team added

comment:5 Changed 8 months ago by pili

Points: 0.5

comment:6 Changed 8 months ago by pospeselr

Owner: changed from mcs to pospeselr

#30783 added this

comment:7 Changed 8 months ago by pospeselr

Keywords: TorBrowserTeam201912R added; TorBrowserTeam201912 removed
Status: assignedneeds_review

Rebased tor-button master and dropped:

  • 1b10bf33beac6bdaad744adc3318c6d7ccdb8c72
  • 5e80a7f316bea85e6c01af96fea05ba57a367f06
  • b75147e1d866ebe1c2be4100ba54fe2e4b7bf321
  • c0438bdcd48215fb73425f448ee1e5e9f5e4dbe3
  • 9ea41dcdc38c79368a0909f4a64fcb865bd39af2
  • ce795172f37ee2a43a8e7de0c0d06816143880ad

Created a diff of that, and applied to master, then went back and brought back various translation updates unrelated to the EOY campaign. As a result, the dtd changes should include just the <!-- End of year 2019 Fundraising campaign --> blocks. This change also removes the embedded fonts and the license update needed by the fonts.

Made a fresh build and can confirm, we're back to the usual purple about:tor and we don't get any errors or complaints in the debug log when loading the page.

tor-button: https://gitweb.torproject.org/user/richard/torbutton.git/commit/?h=bug_31855

Last edited 8 months ago by pospeselr (previous) (diff)

comment:8 Changed 8 months ago by mcs

r=brade, r=mcs
The patch looks good to us. Thanks for taking care of this ticket!

comment:9 Changed 8 months ago by sysrqb

Resolution: fixed
Status: needs_reviewclosed

Okay, I think this looks good. Let's see how this looks in the nightly. Merged as commit 0e5ac5d22f59487d857fea57dd3db69daf2e56d2

comment:10 Changed 8 months ago by sysrqb

Keywords: tbb-backport added
Resolution: fixed
Status: closedreopened

I need to remember to land this on stable, too.

comment:11 Changed 7 months ago by sysrqb

Resolution: fixed
Status: reopenedclosed

And this was cherry-picked as commit 61ccbe66353e84b33147490d4080d58f8f7fdf46 on maint-9.0.

comment:12 Changed 7 months ago by gk

Keywords: tbb-backported added; tbb-backport removed
Note: See TracTickets for help on using tickets.