Remove End of Year Fundraising Campaign from about:tor
At the start of 2020, we should remove the EOY Fundraising elements from Tor Browser
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Author
Trac:
Summary: Remove End of Year Fundraising Campaign Banner to Remove End of Year Fundraising Campaign from about:tor - Author
Trac:
Keywords: TorBrowserTeam202001 deleted, TorBrowserTeam201912 added - Author
Trac:
Status: new to assigned
Owner: tbb-team to mcs Trac:
Cc: N/A to tbb-team- Author
Trac:
Points: N/A to 0.5 #30783 (moved) added this
Trac:
Owner: mcs to pospeselrRebased tor-button master and dropped:
- 1b10bf33beac6bdaad744adc3318c6d7ccdb8c72
- 5e80a7f316bea85e6c01af96fea05ba57a367f06
- b75147e1d866ebe1c2be4100ba54fe2e4b7bf321
- c0438bdcd48215fb73425f448ee1e5e9f5e4dbe3
- 9ea41dcdc38c79368a0909f4a64fcb865bd39af2
- ce795172f37ee2a43a8e7de0c0d06816143880ad
Created a diff of that, and applied to master, then went back and brought back various translation updates unrelated to the EOY campaign. As a result, the dtd changes should include just the
<!-- End of year 2019 Fundraising campaign -->
blocks. This change also removes the embedded fonts and the license update needed by the fonts.Made a fresh build and can confirm, we're back to the usual purple about:tor and we don't get any errors or complaints in the debug log when loading the page.
tor-button: https://gitweb.torproject.org/user/richard/torbutton.git/commit/?h=bug_31855
Trac:
Keywords: TorBrowserTeam201912 deleted, TorBrowserTeam201912R added
Status: assigned to needs_reviewr=brade, r=mcs The patch looks good to us. Thanks for taking care of this ticket!
Okay, I think this looks good. Let's see how this looks in the nightly. Merged as commit 0e5ac5d22f59487d857fea57dd3db69daf2e56d2
Trac:
Resolution: N/A to fixed
Status: needs_review to closedI need to remember to land this on stable, too.
Trac:
Keywords: N/A deleted, tbb-backport added
Status: closed to reopened
Resolution: fixed to N/AAnd this was cherry-picked as commit 61ccbe66353e84b33147490d4080d58f8f7fdf46 on maint-9.0.
Trac:
Status: reopened to closed
Resolution: N/A to fixedTrac:
Keywords: tbb-backport deleted, tbb-backported added- Trac closed
closed
- Trac changed time estimate to 4h
changed time estimate to 4h