Opened 2 weeks ago

Last modified 11 days ago

#31884 merge_ready defect

Define ExecuteBash in the Appveyor error block

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version: Tor: 0.3.4.2-alpha
Severity: Normal Keywords: tor-ci-fail-rarely, 042-can, 035-backport, 040-backport, 041-backport, 042-backport, consider-backport-after-ci-passes, BugSmashFund
Cc: catalyst Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: asn Sponsor:

Description

When Appveyor fails before ExecuteBash is defined, it skips straight to the error block. But the error block wants ExecuteBash. So we should define it twice.

Example:
https://ci.appveyor.com/project/nmathewson/tor/build/1.0.850/job/v5mws73je9sihmfn

Child Tickets

Change History (6)

comment:1 Changed 2 weeks ago by teor

Anyone can fix this bug, but I'll try to to it on Monday.

comment:2 Changed 2 weeks ago by teor

Actual Points: 0.1
Keywords: consider-backport-after-0423 BugSmashFund added
Status: assignedneeds_review
Version: Tor: unspecifiedTor: 0.3.4.2-alpha

See my PR:

The test merges are all clean, the branches are here:

comment:3 Changed 13 days ago by asn

Reviewer: asn

comment:4 Changed 11 days ago by asn

Status: needs_reviewmerge_ready

LGTM!

comment:5 Changed 11 days ago by nickm

Milestone: Tor: 0.4.2.x-finalTor: 0.4.1.x-final

Merged to master, marking for backport.

comment:6 Changed 11 days ago by teor

Keywords: consider-backport-after-ci-passes added; consider-backport-after-0423 removed

This is a CI issue, so we can backport it as soon as CI passes,

Note: See TracTickets for help on using tickets.