Opened 7 weeks ago

Closed 11 days ago

#31891 closed defect (duplicate)

make autostyle doesn't work when building outside the source tree

Reported by: catalyst Owned by:
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: easy, maint-scripts, 043-can
Cc: Actual Points:
Parent ID: #31713 Points:
Reviewer: Sponsor: Sponsor31-can

Description

It looks like make autostyle doesn't work correctly if building outside the source tree. (Here I'm building in a subdirectory of the source tree.)

$ make -k autostyle
abs_top_srcdir="/Users/tlyu/src/tor/build-norust/.." python3 ../scripts/maint/update_versions.py
Traceback (most recent call last):
  File "../scripts/maint/update_versions.py", line 98, in <module>
    with open("configure.ac") as f:
FileNotFoundError: [Errno 2] No such file or directory: 'configure.ac'
make: *** [update-versions] Error 1
python3 scripts/maint/annotate_ifdef_directives.py ../src/lib/*/*.[ch] ../src/core/*/*.[ch] ../src/feature/*/*.[ch] ../src/app/*/*.[ch] ../src/test/*.[ch] ../src/test/*/*.[ch] ../src/tools/*.[ch]
/Users/tlyu/src/brew/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/Resources/Python.app/Contents/MacOS/Python: can't open file 'scripts/maint/annotate_ifdef_directives.py': [Errno 2] No such file or directory
make: *** [autostyle-ifdefs] Error 2
python3 scripts/maint/rectify_include_paths.py
/Users/tlyu/src/brew/Cellar/python/3.7.4/Frameworks/Python.framework/Versions/3.7/Resources/Python.app/Contents/MacOS/Python: can't open file 'scripts/maint/rectify_include_paths.py': [Errno 2] No such file or directory
make: *** [rectify-includes] Error 2
make: Target `autostyle' not remade because of errors.

Child Tickets

Change History (3)

comment:1 Changed 7 weeks ago by teor

Parent ID: #31713

We'll need to fix this issue, if we want to run "make autostyle" in a git hook

comment:2 Changed 3 weeks ago by teor

Keywords: 043-can added
Milestone: Tor: unspecifiedTor: 0.4.3.x-final
Sponsor: Sponsor31-can

comment:3 Changed 11 days ago by teor

Resolution: duplicate
Status: newclosed

I fixed this issue in #32370, because I needed "make autostyle" for #32213.

Note: See TracTickets for help on using tickets.