util/map_anon_nofork test fails on SunOS
I get the following error on SunOS:
uname -a SunOS oibuild 5.11 illumos-e7a617a7b6 i86pc i386 i86pc
....
FAIL: src/test/test
===================
util/load_win_lib: SKIPPED
util/log_mallinfo: SKIPPED
util/map_anon_nofork:
FAIL /export/home/svschmel/oi-userland/components/network/tor/tor-0.4.1.6/src/test/test_util.c:6223: assert(buf[0] OP_EQ 0xd0): -48 vs 208
[map_anon_nofork FAILED]
1/1360 TESTS FAILED. (2 skipped)
FAIL src/test/test (exit status: 1)
....Trac:
Username: svschmel
Activity
changed milestone to %Tor: 0.4.1.x-final
Trac:
Child Ticket(s): #31948 (moved)added 041-backport 041-regression 042-must BugSmashFund actualpoints::0.1 component::core tor/tor consider-backport-after-04233 fast-fix milestone::Tor: 0.4.1.x-final owner::teor points::0.1 priority::high reporter::svschmel resolution::fixed reviewer::ahf severity::normal status::closed tor-test type::defect version::tor 0.4.1.1-alpha labels
-
Trac:
Username: svschmel See my PR:
The merge to master was clean, here is the test PR:
Trac:
Actualpoints: N/A to 0.1
Keywords: N/A deleted, 041-backport, BugSmashFund, consider-backport-after-0433 added
Status: assigned to needs_review-
Hello,
i can commit that this fix works. Quick and dirty test:
svschmel@oibuild:~/oi-userland/components/network/tor/tor-0.4.1.6/src/test$ wget https://raw.githubusercontent.com/torproject/tor/2420c8c9366e498dfaf3b4b6389ece9dc27ca537/src/test/test_util.c
--2019-10-01 12:29:26-- https://raw.githubusercontent.com/torproject/tor/2420c8c9366e498dfaf3b4b6389ece9dc27ca537/src/test/test_util.c Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 151.101.112.133 Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|151.101.112.133|:443... connected. HTTP request sent, awaiting response... 200 OK Length: 202187 (197K) [text/plain] Saving to: 'test_util.c.1'
test_util.c.1 100%[=================================================================>] 197.45K --.-KB/s in 0.1s
2019-10-01 12:29:26 (1.61 MB/s) - 'test_util.c.1' saved [202187/202187]
...
svschmel@oibuild:~/oi-userland/components/network/tor/tor-0.4.1.6/src/test$ ls -al test_uti* -rw-r--r-- 1 svschmel staff 202147 Jun 10 14:46 test_util.c -rw-r--r-- 1 svschmel staff 202187 Oct 1 12:29 test_util.c.1 -rw-r--r-- 1 svschmel staff 11624 Jun 10 14:46 test_util_format.c -rw-r--r-- 1 svschmel staff 1814 Jun 10 14:46 test_util_process.c
...
svschmel@oibuild:~/oi-userland/components/network/tor/tor-0.4.1.6/src/test$ cp test_util.c.1 test_util.c
...
svschmel@oibuild:~/oi-userland/components/network/tor$ gmake test (cd /export/home/svschmel/oi-userland/components/network/tor/build/amd64 ;
/usr/bin/env PATH=/usr/gnu/bin:/usr/bin:/usr/sbin:/usr/perl5/bin
/usr/gnu/bin/make
check) make[1]: Entering directory '/export/home/svschmel/oi-userland/components/network/tor/build/amd64' CC src/test/src_test_test-test_util.o CCLD src/test/test /usr/gnu/bin/make check-TESTS check-local make[2]: Entering directory '/export/home/svschmel/oi-userland/components/network/tor/build/amd64' make[3]: Entering directory '/export/home/svschmel/oi-userland/components/network/tor/build/amd64' PASS: src/test/test PASS: src/test/test-slow PASS: src/test/test-memwipe PASS: src/test/test_workqueue PASS: src/test/test_keygen.sh PASS: src/test/test_key_expiration.sh PASS: src/test/test-timers SKIP: src/test/fuzz_static_testcases.sh PASS: src/test/test_zero_length_keys.sh PASS: src/test/test_workqueue_cancel.sh PASS: src/test/test_workqueue_efd.sh PASS: src/test/test_workqueue_efd2.sh PASS: src/test/test_workqueue_pipe.sh PASS: src/test/test_workqueue_pipe2.sh PASS: src/test/test_workqueue_socketpair.sh SKIP: src/test/test_switch_id.sh PASS: src/test/test_ntor.sh SKIP: src/test/test_hs_ntor.sh PASS: src/test/test_bt.sh PASS: src/test/test_rebind.shTestsuite summary for tor 0.4.1.6
TOTAL: 20
PASS: 17
SKIP: 3
XFAIL: 0
FAIL: 0
XPASS: 0
ERROR: 0
============================================================================ make[3]: Leaving directory '/export/home/svschmel/oi-userland/components/network/tor/build/amd64' perl /export/home/svschmel/oi-userland/components/network/tor/tor-0.4.1.6/scripts/maint/checkSpace.pl -C
/export/home/svschmel/oi-userland/components/network/tor/tor-0.4.1.6/src/lib//.[ch] /export/home/svschmel/oi-userland/components/network/tor/tor-0.4.1.6/src/core//.[ch] /export/home/svschmel/oi-userland/components/network/tor/tor-0.4.1.6/src/feature//.[ch] /export/home/svschmel/oi-userland/components/network/tor/tor-0.4.1.6/src/app//.[ch] /export/home/svschmel/oi-userland/components/network/tor/tor-0.4.1.6/src/test/.[ch] /export/home/svschmel/oi-userland/components/network/tor/tor-0.4.1.6/src/test//.[ch] /export/home/svschmel/oi-userland/components/network/tor/tor-0.4.1.6/src/tools/.[ch] python3 /export/home/svschmel/oi-userland/components/network/tor/tor-0.4.1.6/scripts/maint/checkIncludes.py if command -v shellcheck; then
find /export/home/svschmel/oi-userland/components/network/tor/tor-0.4.1.6/scripts/ -name "*.sh" -exec shellcheck {} +;
if [ -d "/export/home/svschmel/oi-userland/components/network/tor/tor-0.4.1.6/scripts/test" ]; then
shellcheck /export/home/svschmel/oi-userland/components/network/tor/tor-0.4.1.6/scripts/test/cov-diff /export/home/svschmel/oi-userland/components/network/tor/tor-0.4.1.6/scripts/test/coverage;
fi;
fi make[2]: Leaving directory '/export/home/svschmel/oi-userland/components/network/tor/build/amd64' make[1]: Leaving directory '/export/home/svschmel/oi-userland/components/network/tor/build/amd64' /usr/bin/touch /export/home/svschmel/oi-userland/components/network/tor/build/amd64/.testedTrac:
Username: svschmel I cherry-picked #31948 (moved) to the 0.4.1 backport branch, because it is a fix on this change.
Merged to 0.4.1 and later. Merged #31107 (moved), #31466 (moved), #30916 (moved), #31408 (moved), #31837 (moved), and #31897 (moved) together.
Trac:
Resolution: N/A to fixed
Status: merge_ready to closedmentioned in issue #31948 (moved)
moved to tpo/core/tor#31897 (closed)
