Opened 4 months ago

Closed 4 months ago

#31907 closed task (fixed)

Add comments to prevent recurrence of #31495

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 042-should comment
Cc: Actual Points: 0
Parent ID: Points: 0
Reviewer: teor Sponsor: Sponsor31-can

Description

From #31611:

We can document more carefully the dangers of configuration values where NULL and "" mean different things. (In the case of EntryNodes, NULL means "all nodes are included", and "" means "no nodes are included".)

We've decided that we should do this in 0.4.2.

Child Tickets

Change History (2)

comment:1 Changed 4 months ago by nickm

Actual Points: 0
Keywords: 042-should added; 042-can removed
Status: assignedneeds_review

Branch is ticket31907 with PR at https://github.com/torproject/tor/pull/1384

(No changes file, since this is a comments-only change)

Putting right into needs_review since this is a comments-only change.

comment:2 Changed 4 months ago by teor

Resolution: fixed
Status: needs_reviewclosed

Looks good to me.

Since this is a comment-only change, I merged it directly to master.

Note: See TracTickets for help on using tickets.