Opened 4 months ago

Closed 6 weeks ago

#31909 closed defect (fixed)

Write a stem test to detect #31495 regression

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Archived/Stem Version:
Severity: Normal Keywords: 042-should
Cc: atagar Actual Points:
Parent ID: Points:
Reviewer: atagar Sponsor: Sponsor31-can

Description

We should make a test that tries to do SETCONF UseBridges=1 Bridge="127.0.0.1:1234" to make sure that the setconf is not rejected.

Atagar, are the stem tests a good place to put tor regression tests? If so, what would be the best place in the test hierarchy?

Child Tickets

Change History (8)

comment:1 Changed 4 months ago by nickm

Owner: changed from atagar to nickm
Status: newaccepted

comment:2 Changed 4 months ago by nickm

Status: acceptedneeds_information

comment:3 Changed 4 months ago by atagar

Hi Nick. Below test_set_conf() would be a good spot...

https://gitweb.torproject.org/stem.git/tree/test/integ/control/controller.py#n714

comment:4 Changed 4 months ago by nickm

Branch is ticket31909; PR in https://github.com/torproject/stem/pull/23

comment:5 Changed 4 months ago by nickm

Status: needs_informationneeds_review

comment:6 Changed 4 months ago by nickm

Reviewer: atagar

comment:7 Changed 3 months ago by atagar

Thanks Nick! I'm digging into another of asn's big hidden service branches (#31823) so it'll probably be a couple weeks before I merge this. Sorry in advance!

comment:8 Changed 6 weeks ago by atagar

Resolution: fixed
Status: needs_reviewclosed

"Couple weeks" I said? Damn me, sorry about that. Finally merged.

Note: See TracTickets for help on using tickets.