Opened 6 weeks ago

Closed 5 weeks ago

Last modified 3 weeks ago

#31910 closed defect (fixed)

replace meek_lite with meek in circuit display

Reported by: mcs Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: meek, tbb-9.0-must-alpha, TorBrowserTeam201910R, ux-team
Cc: tbb-team Actual Points: 0.2
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

Since #29430 was fixed, the Tor Browser circuit display shows "meek_lite" instead of "meek" (this is because the circuit display code gets the PT name from the Tor configuration and obfs4proxy uses "meek_lite" as the name for its meek implementation).

I think it would be better and less confusing if the circuit display showed "meek" as it did in previous versions of Tor Browser. The "lite" part is somewhat misleading given obfs4proxy's use of utls to mimic common TLS ClientHello messages.

Antonela, do you agree? Any other opinions?

(I included the tbb-9.0-must-alpha keyword so we remember to decide about this before we ship Tor Browser 9.0 stable).

Child Tickets

Change History (8)

comment:1 Changed 6 weeks ago by gk

Yes, let's do that. (That's been one of the tickets I meant to file after all the reviewing. Glad you beat me to it)

comment:2 Changed 6 weeks ago by gk

Points: 0.1

comment:3 Changed 6 weeks ago by antonela

I'm thinking about how important it is for end-users to have/known the random name we assign to PTs or Bridges.

Can we have something more generic like: Bridge: Meek or PT: Meek, wherein the short future is just Bridge or PT.

At some point, we can illustrate bridges/PT with an icon at the circuit display, something like this.

comment:4 Changed 6 weeks ago by antonela

Cc: antonela removed
Keywords: ux-team added

comment:5 Changed 5 weeks ago by mcs

Cc: tbb-team added
Owner: changed from tbb-team to mcs
Status: newassigned

comment:6 Changed 5 weeks ago by mcs

Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: assignedneeds_review

For now, we should do the simple thing and restore "Bridge: meek" (so users see the same thing in TB 9.0 as they do in 8.5). Here is a patch:
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug31910-01&id=71bb89e923be7be2388ce77684a06c7782f7a6f4

comment:7 in reply to:  6 Changed 5 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Replying to mcs:

For now, we should do the simple thing and restore "Bridge: meek" (so users see the same thing in TB 9.0 as they do in 8.5). Here is a patch:
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug31910-01&id=71bb89e923be7be2388ce77684a06c7782f7a6f4

Looks good to me, thanks. Cherry-picked to master (commit e54639aab0c60274c14809cd9129b534bb79f92c).

comment:8 Changed 3 weeks ago by mcs

Actual Points: 0.2
Note: See TracTickets for help on using tickets.