Opened 13 months ago

Closed 13 months ago

Last modified 11 months ago

#31929 closed defect (fixed)

&vendorShortName; is escaped in ar breaking the referencing of this entity

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201910, tbb-branding
Cc: emmapeel Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description (last modified by gk)

We have <!ENTITY project.tpoLink "&amp;vendorShortName؛"> in ar's aboutDialog.dtd. Note for comparison, just one line above in that file <!ENTITY project.start "طوّر &brandShortName;">.

The latter is correct as the & and ; are making sure brandShortName as it is translated elsewhere gets included. But that fails if one starts to escape those characters (e.g. by replacing & with &amp).

Thanks to Thorin for reporting this issue.

Child Tickets

Change History (3)

comment:1 Changed 13 months ago by gk

Actual Points: 0.1
Keywords: TorBrowserTeam201910 added
Points: 0.1
Resolution: fixed
Status: newclosed

Fixed with pulling the latest strings from the translations repo (commit b7218ab186ef8d1e1ded5fe9b19eaecfad767be0). Thanks!

comment:2 Changed 13 months ago by gk

Keywords: tbb-branding added

comment:3 Changed 11 months ago by gk

Description: modified (diff)
Note: See TracTickets for help on using tickets.