Opened 6 weeks ago

Closed 4 weeks ago

#31932 closed defect (fixed)

Snowflake LICENSE file is in Docs\snowflake, while others are in Docs\Licenses\PluggableTransports

Reported by: boklm Owned by:
Priority: Low Milestone:
Component: Applications/Tor Browser Version:
Severity: Minor Keywords: TorBrowserTeam201910R snowflake
Cc: tbb-team, arlolra, cohosh, phw, dcf Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Someone reported on the blog that the Snowflake LICENSE file is in directory TorBrowser/Docs while other licenses files are in TorBrowser/Docs/Licenses/PluggableTransports/LICENSE:
https://blog.torproject.org/comment/284257#comment-284257

An other comment is mentioning that the Reproducible build with TBB line in the README can now be checked.

Child Tickets

Attachments (1)

0001-Copy-snowflake-s-license-to-the-bundled-data.patch (3.0 KB) - added by arlolra 5 weeks ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 5 weeks ago by arlolra

Status: newneeds_review

Please see the attached patch. The license files don't seem to be copied over at build time.

While we're here, maybe that license needs updating?

An other comment is mentioning that the Reproducible build with TBB line in the README can now be checked.

Status tracking was removed in,
https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=be7b5315864d6a35be5c085583e73ec0a0adf25b

comment:2 Changed 4 weeks ago by dcf

Component: Circumvention/SnowflakeApplications/Tor Browser
Keywords: TorBrowserTeam201910R snowflake added

It looks good to me. I was surprised that tor-browser-build has its own copy of PT-related licenses, instead of copying the license files from the respective source files, but Arlo's patch is consistent with the way it works for those other PTs.

comment:3 Changed 4 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Applied to master (commit 9b0d98a51abdbad31d131b768e09e9a0c98b3f15), thanks!

Note: See TracTickets for help on using tickets.