Opened 12 days ago

Last modified 12 days ago

#31934 new defect

Proxy or Kill BaseResource

Reported by: sysrqb Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile
Cc: Actual Points:
Parent ID: Points: 0.25
Reviewer: Sponsor:

Description

Mike asked me how we proxy connections from BaseResource. On 60esr, we used a patch for this. That patch was dropped during the rebase becaues I incorrectly thought I neutered BaseResource in the patch for #28125.

I think we're still safe, and we disable all places where BaseResource is used, but let's re-land this patch (or we should kill BaseResource connections), just so we're more certain the app isn't bypassing the proxy.

Child Tickets

Change History (1)

comment:1 in reply to:  description Changed 12 days ago by sysrqb

Replying to sysrqb:

Mike asked me how we proxy connections from BaseResource. On 60esr, we used a patch for this. That patch was dropped during the rebase becaues I incorrectly thought I neutered BaseResource in the patch for #28125.

Oh! I did apply that patch! https://gitweb.torproject.org/tor-browser.git/commit/mobile/android?h=tor-browser-68.1.0esr-9.0-2&id=5e54ff2b421e0a5b7a42acb7028565a5da14991a

Note: See TracTickets for help on using tickets.